This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Rollback #1557
Merged
Rollback #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
suggested changes
Apr 9, 2024
Collaborator
iOvergaard
left a comment
iOvergaard
left a comment
There was a problem hiding this comment.
Looks good, left a few comments for optimization, and you need to add localization in general to the elements 😎
src/packages/documents/documents/modals/rollback/repository/rollback.repository.ts
Show resolved
Hide resolved
...ges/documents/documents/workspace/views/info/document-workspace-view-info-history.element.ts
Outdated
Show resolved
Hide resolved
src/packages/documents/documents/modals/rollback/rollback-modal.token.ts
Show resolved
Hide resolved
iOvergaard
suggested changes
Apr 10, 2024
src/packages/documents/documents/modals/rollback/rollback-modal.element.ts
Outdated
Show resolved
Hide resolved
src/packages/documents/documents/modals/rollback/rollback-modal.element.ts
Outdated
Show resolved
Hide resolved
...ges/documents/documents/workspace/views/info/document-workspace-view-info-history.element.ts
Outdated
Show resolved
Hide resolved
...ges/documents/documents/workspace/views/info/document-workspace-view-info-history.element.ts
Outdated
Show resolved
Hide resolved
...ges/documents/documents/workspace/views/info/document-workspace-view-info-history.element.ts
Outdated
Show resolved
Hide resolved
...ges/documents/documents/workspace/views/info/document-workspace-view-info-history.element.ts
Outdated
Show resolved
Hide resolved
src/packages/documents/documents/modals/rollback/rollback-modal.element.ts
Outdated
Show resolved
Hide resolved
src/packages/documents/documents/modals/rollback/rollback-modal.element.ts
Show resolved
Hide resolved
iOvergaard
approved these changes
Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rollback with diffing
Also adds the package diff. Same package as used in the old backoffice
Also corrects the naming in
document-property-dataset-context.token.ts