Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Conversation

@madsrasmussen
Copy link
Contributor

Description

This PR fixes the problem where entity actions didn't run on the current entity if the context menu isn't closed between actions.

The problem was that the extensions weren't reinitialized when there were new constructor args. It would have been better to be able to also set the values on the API, but it is currently not supported by the API. In the end we need to make this update if the args should change over time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

How to test?

  • Make sure that an entity action is run on the correct entity unique. One way to do it is:
    • Open the context menu for a tree item
    • Try to delete the item and notice the name of the item in the delete dialog
    • Cancel the delete dialog
    • Open the context menu for another tree item without closing it
    • Try to delete the item and notice that the name has changed to the new tree item.

@leekelleher leekelleher self-requested a review April 10, 2024 13:44
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out with the entity action menu, works as expected. 👍

@leekelleher leekelleher merged commit 676f374 into main Apr 10, 2024
@leekelleher leekelleher deleted the bugfix/create-new-extensions-when-constructor-arg-changes branch April 10, 2024 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants