-
Notifications
You must be signed in to change notification settings - Fork 56
Adds Focus story for each uui-ref-node type
#1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1217.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1217.westeurope.azurestaticapps.net |
uui-ref-node-* focus
(removed typescript errors)
(this will prevent any accidental markup typos)
uui-ref-node-* focusFocus story for each uui-ref-node type
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1217.westeurope.azurestaticapps.net |
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out, works as described. Good work! 🙌
I noticed a couple of minor things and found that the Focus story could be simplified, so I made those tweaks to the PR.



Description
Adds a function to set focus for buttons
Types of changes
Motivation and context
Giving us the option to set initial focus when opening modals ( Accessibility feature )
How to test?
The new story provides a button that sets the focus to the DOM with ID #open-part
Screenshots (if appropriate)
Checklist