EventState is not kept between SavingDictionaryItem and SavedDictionaryItem events

[lauraneto]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

8.18.9

Bug summary

The EventState is lost between the SavingDictionaryItem and SavedDictionaryItem events.
This does not happen when the item is first created, it only happens when attempting to save after that.

Tried it in an Umbraco 12 install, using notifications, and there it worked correctly.

Specifics

No response

Steps to reproduce

1. Set up a new Umbraco 8 install (default installation, no content required)
2. Create a new C# file in the project and add the following content:

using Umbraco.Core;
using Umbraco.Core.Composing;
using Umbraco.Core.Events;
using Umbraco.Core.Models;
using Umbraco.Core.Services;
using Umbraco.Core.Services.Implement;

namespace Umbraco8.Web
{
    [RuntimeLevel(MinLevel = RuntimeLevel.Run)]
    public class TestComposer : ComponentComposer<TestComponent> { }

    public class TestComponent : IComponent
    {
        public void Initialize()
        {
            LocalizationService.SavingDictionaryItem += SavingDictionaryItem;
            LocalizationService.SavedDictionaryItem += SavedDictionaryItem;
        }

        private static void SavingDictionaryItem(ILocalizationService sender, SaveEventArgs<IDictionaryItem> e)
        {
            e.EventState["key"] = "This is a test!";
        }

        private static void SavedDictionaryItem(ILocalizationService sender, SaveEventArgs<IDictionaryItem> e)
        {
            var test = e.EventState["key"];
        }

        public void Terminate()
        {
            LocalizationService.SavingDictionaryItem -= SavingDictionaryItem;
            LocalizationService.SavedDictionaryItem -= SavedDictionaryItem;
        }
    }
}

3. Boot up the website
4. Create a new dictionary item (this one works as expected!)
5. Save the same dictionary item (again) 💥
   Verify that you get a System.Collections.Generic.KeyNotFoundException: 'The given key was not present in the dictionary.' due to the EventState being empty.

Expected result / actual result

Expected: The EventState is kept between the SavingDictionaryItem and SavedDictionaryItem
Actual: EventState is empty on SavedDictionaryItem

[github-actions]

Hi there @lauraneto!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[kjac]

Hi @lauraneto,

Thanks for raising this - and with a PR to match, even 😍

The Core Collabs team will review your PR and get back to you on this one.

[nul800sebastiaan]

Fixed in #14912