Skip to content

Conversation

@erikjanwestendorp
Copy link
Contributor

@erikjanwestendorp erikjanwestendorp commented Jan 2, 2024

Description

Update content type:

  • remove 'note that'
  • write shorter sentences

Type of suggestion

  • Styleguide

Product & version (if relevant)

Umbraco CMS v10, 12 & 13

@erikjanwestendorp erikjanwestendorp changed the title Update conent type Update content type Jan 2, 2024
Copy link
Contributor

@alina-tincas alina-tincas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erikjanwestendorp thank you for the PR!

Hope you had nice holidays 😊 ¨

I have noticed for the ID section there was a similar PR where we went with different wording: https://github.com/umbraco/UmbracoDocs/pull/5674/files would you be up for using the same to keep text in the docs consistent? And if you agree, can you please make the change to all versions as suggested? 😊

erikjanwestendorp and others added 2 commits January 2, 2024 15:07
Co-authored-by: Alina-Magdalena Tincas <83591955+alina-tincas@users.noreply.github.com>
@erikjanwestendorp
Copy link
Contributor Author

@alina-tincas I had a great holiday, I hope you too? I just update the PR with your suggestion 😄

Copy link
Contributor

@alina-tincas alina-tincas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I also had a nice holiday however they passed by too fast 😆

I have noticed you have made on v13 docs 1 change that is it not that relevant 🙈

erikjanwestendorp and others added 2 commits January 3, 2024 13:04
Co-authored-by: Alina-Magdalena Tincas <83591955+alina-tincas@users.noreply.github.com>
@erikjanwestendorp
Copy link
Contributor Author

@alina-tincas Holidays always go by too quickly 🙈. Oops my bad... 😅, just updated the PR.

@alina-tincas
Copy link
Contributor

Indeed, and no worries 😊

@alina-tincas alina-tincas merged commit 70fe890 into umbraco:main Jan 4, 2024
@erikjanwestendorp erikjanwestendorp deleted the update-conent-type branch January 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants