-
Notifications
You must be signed in to change notification settings - Fork 811
Mixed typo fixes #5782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed typo fixes #5782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vale error here is confusing me. All sentences here are <25 words as far as I can see.
For customers who joined Umbraco Cloud before 5th of May, 2021, subscriptions can be managed from Umbraco Shop. - 18 words
Umbraco Shop can be accessed through [shop.umbraco.com](https://shop.umbraco.com). - 7 words
You can also click on the **Manage Subscriptions** link from the **Profile** dropdown on the Umbraco Cloud Portal. - 18 words
Find out more in the [Manage Subscriptions](../../set-up/manage-subscriptions/) article. - 10 words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is correct! We are not sure why but sometimes there are some false errors like this one here 🤔In this case it is all right to be merged in as it is 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vale error in this file is being caused by TLS not appearing in the UmbracoDocs.Acronyms file. The sentence doesn't make sense without the reference to TLS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course! This vale error can be fixed by defining TLS like so: Transport Layer Security (TLS)
You can read more about this here: https://docs.umbraco.com/welcome/contribute/style-guide#defined-acronyms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the above and the vale error is now gone 😊
|
Hi @liamlaverty thank you for the PR 🙌 We will take a look at it as soon as we can! 😊 |
umbraco-cloud/getting-started/the-umbraco-cloud-portal/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course! This vale error can be fixed by defining TLS like so: Transport Layer Security (TLS)
You can read more about this here: https://docs.umbraco.com/welcome/contribute/style-guide#defined-acronyms
umbraco-heartcore/getting-started/backoffice-users-and-api-keys.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is correct! We are not sure why but sometimes there are some false errors like this one here 🤔In this case it is all right to be merged in as it is 👍
|
Hi @liamlaverty thank you for this awesome PR #h5YR 🙌 I have just made 2 small changes, otherwise all looks good! 💪 Merging this in 😁 |
Description
Corrected typos in 63 documentation files
Type of suggestion
Product & version (if relevant)
V10, 12, 13
Deadline (if relevant)
N/A