Skip to content

Conversation

@liamlaverty
Copy link
Contributor

Description

Corrected typos in 63 documentation files

Type of suggestion

  • [ ✅] Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

V10, 12, 13

Deadline (if relevant)

N/A

Copy link
Contributor Author

@liamlaverty liamlaverty Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vale error here is confusing me. All sentences here are <25 words as far as I can see.

For customers who joined Umbraco Cloud before 5th of May, 2021, subscriptions can be managed from Umbraco Shop. - 18 words

Umbraco Shop can be accessed through [shop.umbraco.com](https://shop.umbraco.com). - 7 words

You can also click on the **Manage Subscriptions** link from the **Profile** dropdown on the Umbraco Cloud Portal. - 18 words

Find out more in the [Manage Subscriptions](../../set-up/manage-subscriptions/) article. - 10 words

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct! We are not sure why but sometimes there are some false errors like this one here 🤔In this case it is all right to be merged in as it is 👍

Copy link
Contributor Author

@liamlaverty liamlaverty Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vale error in this file is being caused by TLS not appearing in the UmbracoDocs.Acronyms file. The sentence doesn't make sense without the reference to TLS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course! This vale error can be fixed by defining TLS like so: Transport Layer Security (TLS)
You can read more about this here: https://docs.umbraco.com/welcome/contribute/style-guide#defined-acronyms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the above and the vale error is now gone 😊

@alina-tincas
Copy link
Contributor

Hi @liamlaverty thank you for the PR 🙌

We will take a look at it as soon as we can! 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course! This vale error can be fixed by defining TLS like so: Transport Layer Security (TLS)
You can read more about this here: https://docs.umbraco.com/welcome/contribute/style-guide#defined-acronyms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct! We are not sure why but sometimes there are some false errors like this one here 🤔In this case it is all right to be merged in as it is 👍

@alina-tincas
Copy link
Contributor

alina-tincas commented Jan 29, 2024

Hi @liamlaverty thank you for this awesome PR #h5YR 🙌

I have just made 2 small changes, otherwise all looks good! 💪 Merging this in 😁

@alina-tincas alina-tincas merged commit b9896ec into umbraco:main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants