Skip to content

Conversation

@busrasengul
Copy link
Contributor

@busrasengul busrasengul commented Jan 23, 2024

With Forms 13, there's a slight change in the Execute method :)

Type of suggestion

  • [ x] Typo/grammar fix
  • [x ] Updates related to a new version

Product & version (if relevant)

Umbraco 13, Forms 13

With Forms 13, there's a slight change in the Execute method :)
@alina-tincas
Copy link
Contributor

Hi @busrasengul thank you for the PR #h5YR

We will review it as soon as we can 😊

@eshanrnh eshanrnh removed their request for review January 29, 2024 08:36
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to this @busrasengul. Approved from my side - this did change with Forms 13 to be asynchronous, so it's good to have the sample updated to reflect that too.

@eshanrnh eshanrnh merged commit 65444c5 into umbraco:main Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants