Skip to content

Conversation

@MMasey
Copy link
Contributor

@MMasey MMasey commented Jan 29, 2024

Description

This PR adds an additional way to test the Stipe Payment Provider locally, using the Stripe CLI. I found when using the ngrok approach, i would get errors due to the Umbraco Commerce Checkout package redirecting to the default domain, rather than the ngrok domain.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco Commerce - Stripe Payment Provider

@alina-tincas
Copy link
Contributor

Hi @MMasey, thank you for the PR 🙌

We will take a look at the PR as soon as we can! 😊

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, @MMasey 💪 Added couple of styling and doc guidelines suugestions.

MMasey and others added 12 commits February 8, 2024 21:15
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
…g-stripe-webhooks-locally.md

Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
@MMasey
Copy link
Contributor Author

MMasey commented Feb 8, 2024

Thanks @eshanrnh & @umbracotrd, I've committed those suggestions and added that additional step regarding the webhook signing secret too. 😄

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @MMasey 🙌

@eshanrnh eshanrnh merged commit 4b40aae into umbraco:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants