fix grammar mistake #5960
fix grammar mistake #5960
Conversation
alina-tincas
left a comment
alina-tincas
left a comment
There was a problem hiding this comment.
Hi @abdelrahmanAbouelkheir thank you for the PR 🙌
I have noticed as well that if you head to https://github.com/umbraco/UmbracoDocs/pull/5960/files you can see a warning mentioning to write shorter sentences, less than 25 words. This is one of our styleguides to make our documentation more readable: https://docs.umbraco.com/welcome/contribute/style-guide#long-sentences
I have made a suggestion based on this, so I was wondering if you can take a look at my suggestions and let me know what you think? 😊
Also, I was wondering if you would be up for making the same changes for v12 and v10 of CMS as well, just to keep the content consistent throughout our documentation versions? 💡
| * To return alternative templates depending on some custom business logic | ||
|
|
||
| This replacement of the default controller can either be made 'globally' for all requests (see last example) or by _'hijacking'_ requests for types of pages based on their specific Document Type following a this controller naming convention: `[DocumentTypeAlias]Controller`. | ||
| This replacement of the default controller can either be made 'globally' for all requests (see last example) or by _'hijacking'_ requests for types of pages based on their specific Document Type following this controller naming convention: `[DocumentTypeAlias]Controller`. |
There was a problem hiding this comment.
resolving a styleguide to have shorter sentences less than 25 words as well: https://docs.umbraco.com/welcome/contribute/style-guide#long-sentences
| This replacement of the default controller can either be made 'globally' for all requests (see last example) or by _'hijacking'_ requests for types of pages based on their specific Document Type following this controller naming convention: `[DocumentTypeAlias]Controller`. | |
| This replacement of the default controller can be made 'globally' for all requests (see last example). It can also be by _'hijacking'_ requests for types of pages based on their specific Document Type following this controller naming convention: `[DocumentTypeAlias]Controller`. |
There was a problem hiding this comment.
Hi @alina-tincas thanks for the suggestion
I will fix them in version 10 and 12 right away
There was a problem hiding this comment.
thank you for making the changes #h5YR
As you have created a new PR with new changes for the other versions in #5964 am closing this one 💪
2 participants
Description
Fixed grammar mistake by removing an extra 'a'.
Type of suggestion
Product & version (if relevant)
Umbraco CMS v13