-
Notifications
You must be signed in to change notification settings - Fork 811
Add umbraco commerce product feed package #6007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alina-tincas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @umbracotrd thank you for the PR! 🙌
In order for the new content to match with the current deploy and checkout article structure, can you please take a look at my suggestions?
alina-tincas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few changes
|
|
||
| 2. Locate where you [register the dependencies](https://docs.umbraco.com/umbraco-commerce/key-concepts/umbraco-commerce-builder#registering-dependencies) `IUmbracoBuilder.AddUmbracoCommerce()` and add a call to `IUmbracoCommerceBuilder.AddCommerceProductFeeds()` to add this plugin to your website. | ||
|
|
||
| umbracoBuilder.AddUmbracoCommerce(ucBuilder => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix this code block after am merging it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
|
I have made some few adjustments to speed up the process. @umbracotrd and @BoletteKern I was wondering if you have any further inputs about this PR or is it okay to go ahead and merge it? You can also find a live preview of the content here: https://docs.umbraco.com/umbraco-commerce-packages/~/revisions/yiJb23vHuQXO6tbpgr3c/ |
|
@alina-tincas : I modified the Upgrading section a little bit. The rest looks ok to me. |
|
It looks good, @alina-tincas 🤝 Thanks for your help! |
|
Thank you for confirmation both of you 🎉 ✨ Merging this in 🙌 |
Description
Type of suggestion
Product & version (if relevant)
Umbraco Commerce Product Feed package for Umbraco Commerce 13
Deadline (if relevant)
No pressure.