Skip to content

Conversation

@umbracotrd
Copy link
Contributor

@umbracotrd umbracotrd commented Apr 5, 2024

Description

  • Add a new page for a new package

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco Commerce Product Feed package for Umbraco Commerce 13

Deadline (if relevant)

No pressure.

Copy link
Contributor

@alina-tincas alina-tincas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @umbracotrd thank you for the PR! 🙌

In order for the new content to match with the current deploy and checkout article structure, can you please take a look at my suggestions?

Copy link
Contributor

@alina-tincas alina-tincas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes


2. Locate where you [register the dependencies](https://docs.umbraco.com/umbraco-commerce/key-concepts/umbraco-commerce-builder#registering-dependencies) `IUmbracoBuilder.AddUmbracoCommerce()` and add a call to `IUmbracoCommerceBuilder.AddCommerceProductFeeds()` to add this plugin to your website.

umbracoBuilder.AddUmbracoCommerce(ucBuilder => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this code block after am merging it in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@alina-tincas
Copy link
Contributor

I have made some few adjustments to speed up the process. @umbracotrd and @BoletteKern I was wondering if you have any further inputs about this PR or is it okay to go ahead and merge it? You can also find a live preview of the content here: https://docs.umbraco.com/umbraco-commerce-packages/~/revisions/yiJb23vHuQXO6tbpgr3c/

@umbracotrd
Copy link
Contributor Author

@alina-tincas : I modified the Upgrading section a little bit. The rest looks ok to me.

@BoletteKern
Copy link
Contributor

It looks good, @alina-tincas 🤝 Thanks for your help!

@alina-tincas
Copy link
Contributor

Thank you for confirmation both of you 🎉 ✨

Merging this in 🙌

@alina-tincas alina-tincas merged commit 9e52d24 into umbraco:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants