Update mapping #6056
Merged
Update mapping #6056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-tincas
requested changes
Apr 29, 2024
Contributor
alina-tincas
left a comment
alina-tincas
left a comment
There was a problem hiding this comment.
Hi @erikjanwestendorp thank you for the PR 🙌
All looks good except that somehow on v10 you have replaced 2 sentences with each other 🙈
10/umbraco-cms/reference/mapping.md
Outdated
Comment on lines
9
to
15
| {% hint style="info" %} | ||
| UmbracoMapper replaced AutoMapper which was an external dependency. AutoMapper builds the mapping code dynamically, based upon mapping profiles, which are defined as C# expressions. UmbracoMapper relies on static code, i.e. mappings need to be hand-written. | ||
| UmbracoMapper was originally introduced to solve some issues in the Umbraco core code. However, it is fine for anyone to use in their custom site implementations or packages as they wish. | ||
|
|
||
| This is not to be confused with the [UmbracoMapper package by Andy Butland](https://our.umbraco.com/packages/developer-tools/umbraco-mapper) of the same name. | ||
| {% endhint %} | ||
|
|
||
| UmbracoMapper was originally introduced to solve some issues in the Umbraco core code, however it is totally fine for anyone to use in their custom site implementations or packages as they wish. | ||
| UmbracoMapper replaced AutoMapper which was an external dependency. AutoMapper builds the mapping code dynamically, based upon mapping profiles, which are defined as C# expressions. UmbracoMapper relies on static code, that is, mappings need to be hand-written. |
Contributor
There was a problem hiding this comment.
I suggest to leave back the sentence with UmbracoMapper replaced AutoMapper in the hint note, as usually we list changes in hints note and in this case it makes sense to leave this in a hint note. Then with the sentence UmbracoMapper was originally introduced you can move this above the hint note or after the hint as it was💡
alina-tincas
reviewed
May 1, 2024
Contributor
alina-tincas
left a comment
alina-tincas
left a comment
There was a problem hiding this comment.
making those changes as it it only in 1 file
alina-tincas
approved these changes
May 1, 2024
Contributor
Author
|
@alina-tincas Sorry! I completely forgot about this one 😅 |
Contributor
|
No worries, I just noticed that I can also make the changes 🙈 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update mapping:
Type of suggestion
Product & version (if relevant)
Umbraco CMS v10, 12, 13 & 14