Update limit-orderline-quantity.md #6190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_productService.GetProductStock()` does not have a method accepting a single argument, so updated to use `_productService.GetProductStock(evt.Order.StoreId, productReference)` storeId and productReference
OrderLines are empty on an OrderProductAdd event so you can simply use the order.Quantity value. Also updated the stock check to fail IF quantity greater than stock (remove equal to)
Wrong property
Contributor
Author
|
When adding a product to a new order/cart, the OrderLines are empty so you will need to use the If an order/cart already exists and you are adding a product then the OrderLines do exist. |
Contributor
|
Thanks, @Wiggee11 for the PR 🙌 We will take a look as soon as we can 🙂 |
eshanrnh
reviewed
Jul 2, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
The changes looks good to me. 🙌 Indeed, the GetProductStock method requires 2 arguments.
Thanks for updating the code.
eshanrnh
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_productService.GetProductStock()does not have a method accepting a single argument, so updated to use_productService.GetProductStock(evt.Order.StoreId, productReference)- includestoreId.AddProduct handlers was also checking orderlines for quantity but orderlines are empty, and checking stock value incorrectly.
Product & version (if relevant)
Umbraco 13.3.0
Umbraco.Commerce 13.1.1