Skip to content

Added missing information for validation and notification events #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 27, 2024
Merged

Added missing information for validation and notification events #6202

merged 15 commits into from
Jun 27, 2024

Conversation

@eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Jun 20, 2024 •
edited
Loading

Description

  • Added content for v14
  • Added missing descriptions/information for validation and notification events

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@eshanrnh eshanrnh marked this pull request as ready for review June 26, 2024 07:18
@eshanrnh eshanrnh marked this pull request as draft June 26, 2024 07:50
@eshanrnh eshanrnh marked this pull request as ready for review June 26, 2024 08:24
@eshanrnh eshanrnh requested a review from mattbrailsford June 26, 2024 08:24
@eshanrnh eshanrnh changed the title Adding missing information for validation and notification events Added missing information for validation and notification events Jun 26, 2024
@eshanrnh eshanrnh added the review/developer Use this label if an internal developer review is required label Jun 26, 2024
mattbrailsford
mattbrailsford approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mattbrailsford mattbrailsford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

sofietoft
sofietoft reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookgs great @eshanrnh ! 💪
I've added a couple of comments.

Also, is it correct that an article was moved? Cause then I think we also need a redirect here!

@eshanrnh eshanrnh requested a review from sofietoft June 27, 2024 09:12
@eshanrnh
Copy link
Contributor Author

eshanrnh commented Jun 27, 2024

Thanks, @sofietoft for your review 🙌

You are right. An article was moved into a folder and renamed. I've added a redirect 💪

sofietoft
sofietoft reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering the suggestions 🙌

I've added a final comment regarding the readme file name 😅

@eshanrnh eshanrnh merged commit 8c94356 into main Jun 27, 2024
@eshanrnh eshanrnh deleted the Validation-notification-events branch July 2, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbrailsford mattbrailsford mattbrailsford approved these changes

@sofietoft sofietoft sofietoft approved these changes

Assignees

No one assigned

Labels

category/umbraco-commerce review/developer Use this label if an internal developer review is required review/docsteam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eshanrnh @mattbrailsford @sofietoft