15: Rich Text Editor Tiptap #6498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanrnh
approved these changes
Nov 6, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good to me, @sofietoft 🙌 Just some minor suggestions w.r.t grammar, spellings. Nothing major 😀
...office/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/README.md
Outdated
Show resolved
Hide resolved
...office/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/README.md
Outdated
Show resolved
Hide resolved
...office/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/README.md
Outdated
Show resolved
Hide resolved
...office/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/README.md
Outdated
Show resolved
Hide resolved
| This article is a work in progress and may undergo further revisions, updates, or amendments. The information contained herein is subject to change without notice. | ||
| {% endhint %} | ||
|
|
||
| The Rich Text Editor (RTE) is based on [tinymce](https://www.tinymce.com/) and is highly configurable. Depending on the configuration, it will give your content editors more flexibility when working with content that should be more than only plain text. |
Contributor
There was a problem hiding this comment.
Suggested change
| The Rich Text Editor (RTE) is based on [tinymce](https://www.tinymce.com/) and is highly configurable. Depending on the configuration, it will give your content editors more flexibility when working with content that should be more than only plain text. | |
| The Rich Text Editor (RTE) is highly configurable and based on [TinyMCE](https://www.tinymce.com/). Depending on the configuration, it will give your content editors more flexibility when working with content that should be more than plain text. |
...koffice/property-editors/built-in-umbraco-property-editors/rich-text-editor/configuration.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/rich-text-editor/configuration.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/rich-text-editor/configuration.md
Outdated
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/rich-text-editor/configuration.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/data/data-types/default-data-types.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @eshanrnh ! I've made some changes based on your suggestions - all images and links should be correct now. Let me know what you think! |
eshanrnh
reviewed
Nov 7, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good to me, @sofietoft 🙌 Just noticed some more things while previewing the PR.
| # Styles | ||
|
|
||
| It is possible to define specific styles and fonts for the Rich Text Editor (RTE). Once you have defined the styles, and enabled them on the RTE Data Type, the styles can be accessed directly in the Content section. | ||
|
|
Contributor
There was a problem hiding this comment.
This image is not rendering in the preview.
...ffice/property-editors/built-in-umbraco-property-editors/rich-text-editor-tinymce/plugins.md
Show resolved
Hide resolved
...koffice/property-editors/built-in-umbraco-property-editors/rich-text-editor/configuration.md
Show resolved
Hide resolved
Contributor
Author
|
Thanks again @eshanrnh 💪 Now I've finally caught everything. |
Contributor
|
Looks perfect 🙌 Thanks for applying the suggestions 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Umbraco 15 introduces a new Rich Text Editor UI, Tiptap.
Type of suggestion
Product & version (if relevant)
15.0.0
Deadline (if relevant)
November 14th, or anytime before.