Skip to content

Conversation

@marcemarc
Copy link
Contributor

@marcemarc marcemarc commented Dec 3, 2024

Update the helpful JSON for licences to match the structure of the key

Description

Updated

"Umbraco": {
  "Licenses": {
    "Products": {
      "Umbraco.Commerce": "YOUR_LICENSE_KEY"
    }
  }
}

to be

"Umbraco": {
  "Licenses": {
      "Umbraco.Commerce": "YOUR_LICENSE_KEY"
  }
}

to match the structure of the key

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

V13+

Deadline (if relevant)

Can be updated anytime

Update the helpful settings key for licences to match the structure of the JSON
Products shouldn't be in the JSON!, the key was correct
@sofietoft
Copy link
Contributor

sofietoft commented Dec 3, 2024

Thanks @marcemarc !

I can see that the "products" part here was added only three weeks ago 🤔
If you checkout the docs for version 13 (as you mention), it still uses the structure that you're adding here.

So!
I believe the added "products" is how the licenses are handled from 15/14+ 😁

@sofietoft
Copy link
Contributor

Hi @marcemarc !

Just had Matt confirm this:

Umbraco => 14:

"Umbraco": {
  "Licenses": {
    "Products": {
      "Umbraco.Commerce": "YOUR_LICENSE_KEY"
    }
  }
}

Umbraco =< 13

"Umbraco": {
  "Licenses": {
      "Umbraco.Commerce": "YOUR_LICENSE_KEY"
  }
}

So, the current docs is correct 😁

@sofietoft sofietoft closed this Dec 3, 2024
@marcemarc
Copy link
Contributor Author

@sofietoft @mattbrailsford first commit I made to branch was to add 'products' to the key as I spotted key doesn't match the JSON...
..
Are you saying in v15 the key is not Umbraco:Licenses:Products:Umbraco.Commerce

And should be
Umbraco:Licenses:Umbraco.Commerce

I think the key needs to match the JSON structure??

I think in the docs, people will cut and paste the provided key to put into their Azure Portals, perhaps not even looking at the JSON?

Just feels odd to have them different on the page in the documentation????
Screenshot_20241210_225828_com_android_chrome_ChromeTabbedActivity

@mattbrailsford
Copy link
Contributor

In v14+ there is now the extra ‘Product’ segment so if we’ve missed that somewhere we should update that for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants