Update Defaults for Color and Look on External Providers config #6769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you add/update/change?
When setting either the 'color' or the 'look' of the button for the external providers login button , although the settings come from the UUI link provided.. we are specifying the default values for the wrong thing in the list... so 'Color' can either be Default, Positive, Warning, Danger and
'Look' can be either Primary, Secondary, Outline or Placeholder
But we say here the default for color is 'secondary' and default for Look is 'default'
but they should be the other way around!!!
This PR flips them so they match the implementation
I've also added examples of what the colors are because, they are sort of historically bootstrappy names and not 'actual' colors :-P
Someone setting a property called 'color' might expect to be able to set it to a #hex reference or a color eg blue, but actually the options are not colors at all just words! I think although the info is 'there' in the UUI Colour link, it's not clear which one is which, bourne out by the fact that we've documented it wrong here, so maybe just listing the options as I've done here is helpful? but maybe less is more, and the link to the UUI library tells the full story!
Type of suggestion
Product & version (if relevant)
Umbraco 15
Deadline (if relevant)
When should the content be published?
Now