2FA article for Umbraco 15 #6821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanrnh
approved these changes
Jan 28, 2025
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good to me, @sofietoft 🙌 I've added few suggestions please let me know if something doesn't make sense,
| At this point, the 2FA is active, but no members have set up 2FA yet. The setup of 2FA depends on the type. In the case of App Authenticator, we will add the following to our **view** showing the edit profile of the member. | ||
| At this point, the 2FA is active, but no members have set up 2FA yet. The setup of 2FA depends on the type. In the case of App Authenticator, add the following to the **view** showing the edit profile of the member. | ||
|
|
||
| 7. Add or choose a members-only page that should have the two-factor authentication setup. |
Contributor
There was a problem hiding this comment.
Should step 7 be moved above the para or at the end of step 11? Currently, the para says " add the following to the view showing the edit profile of the member." then point 7 and then the code of the para which is confusing.
Does it make sense what I am trying to say? 🤞😅
Contributor
Author
There was a problem hiding this comment.
I've updated the paragraph, and added a hint about how you can skip a step if you already have a page set up of editing member profiles.
Contributor
Author
There was a problem hiding this comment.
@eshanrnh - let me know if it makes sense.
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
eshanrnh
approved these changes
Jan 29, 2025
| At this point, the 2FA is active, but no members have set up 2FA yet. The setup of 2FA depends on the type. In the case of App Authenticator, we will add the following to our **view** showing the edit profile of the member. | ||
| At this point, the 2FA is active, but no members have set up 2FA yet. The setup of 2FA depends on the type. In the case of App Authenticator, add the following to the **view** showing the edit profile of the member. | ||
|
|
||
| 7. Add or choose a members-only page that should have the two-factor authentication setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the steps for setting up 2FA for both Members and Users.
No changes are made to code, as everything was working as expected.
Type of suggestion
Product & version (if relevant)
CMS 15.