Skip to content

Conversation

@drpeck
Copy link
Contributor

@drpeck drpeck commented Mar 12, 2025

Appears to require IProductAdapter to work (v13)

Description

umbracoCommerceBuilder.Services.AddUnique<ProductAdapterBase, MyCustomProductAdapter>();
to
umbracoCommerceBuilder.Services.AddUnique<IProductAdapter, MyCustomProductAdapter>();

Although IProductAdapter is obsolete, using ProductAdapterBase as the service does not appear to result in the implementation being called

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

13.2.0

Deadline (if relevant)

When should the content be published?

Appears to require IProductAdapter to work (v13)
@sofietoft
Copy link
Contributor

Thanks for the PR @drpeck 💪

I'll make sure we review this as soon as possible.

@sofietoft
Copy link
Contributor

Hi again @drpeck !

Changes are (of course) correct.
Would you be up for applying it to versions 14 and 15 as well?
You can do it in the same PR if you'd like.

No worries if you're not up for it - then I'll take care of it, once this PR is merged 💪
Let me know!
And thanks again for helping us keep the docs up to speed 😁

drpeck added 2 commits March 13, 2025 10:11
IProductAdapter is the service dependency update to v14
IProductAdapterIProductAdapter is the service dependency update to v15
@drpeck
Copy link
Contributor Author

drpeck commented Mar 13, 2025

No problem @sofietoft. All done.

@sofietoft
Copy link
Contributor

Amazing! Thanks 😄

I'll get it merged 💪

@sofietoft sofietoft merged commit 25843dc into umbraco:main Mar 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants