Adds in an example to show how you can use the values inside a manifest #6957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @warrenbuckley for the PR 🙌 We will take a look as soon as we can 💪 |
eshanrnh
approved these changes
Mar 24, 2025
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
The PR looks good. I've added a couple of suggestions to fix the vale warnings regarding long sentences.
eshanrnh
reviewed
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you add/update/change?
The example of the dashboard localization shows this, but its good to show this as an example with the different approaches on how to use/consume the localizations rather than find it in an example that is hard to spot IMO.
Type of suggestion
Product & version (if relevant)
15.x
Deadline (if relevant)
When should the content be published?
None - whenever you feel like and feel free to improve my copy/grammar 😄