-
Notifications
You must be signed in to change notification settings - Fork 811
Change UmbPropertyValueChangeEvent to UmbChangeEvent and updates wrong import paths #6982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… `UmbPropertyValueChangeEvent` to `UmbChangeEvent`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates code examples and documentation to reflect the removal of UmbPropertyValueChangeEvent in favor of UmbChangeEvent, aligning import paths and coding practices with the latest V15 guidelines. Key changes include the following:
- Replacing event dispatches from UmbPropertyValueChangeEvent to UmbChangeEvent.
- Updating import paths for property editors and related modules.
- Adding attributes (lineNumbers and overflow) to code block examples for improved readability.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| 15/umbraco-forms/developer/extending/adding-a-fieldtype.md | Updated event dispatch and import path changes for property editors. |
| 15/umbraco-cms/tutorials/creating-a-property-editor/integrating-context-with-a-property-editor.md | Revised private field naming and updated event dispatch usages. |
| 15/umbraco-cms/tutorials/creating-a-property-editor/adding-configuration-to-a-property-editor.md | Similar updates to event dispatch and import paths. |
| 15/umbraco-cms/tutorials/creating-a-property-editor/README.md | Documentation fixes including TypeScript spelling and code block formatting tweaks. |
| 15/umbraco-cms/customizing/property-editors/composition/property-editor-ui.md | Adjusted code examples to use the new event and import standards. |
| Other files | Minor consistency and formatting updates across various tutorials and extension examples. |
Comments suppressed due to low confidence (3)
15/umbraco-forms/developer/extending/adding-a-fieldtype.md:282
- Ensure that any event listeners or subscribers, previously listening for UmbPropertyValueChangeEvent, are updated to handle the new UmbChangeEvent accordingly.
this.dispatchEvent(new UmbChangeEvent());
15/umbraco-cms/tutorials/creating-a-property-editor/integrating-context-with-a-property-editor.md:41
- [nitpick] Confirm that the adoption of private field naming using '#' aligns with your project's coding standards and is fully supported by your build configuration.
#notificationContext?: UmbNotificationContext;
15/umbraco-cms/tutorials/creating-a-property-editor/README.md:19
- [nitpick] Ensure consistent usage of quotation marks in code examples throughout the documentation, as the diff reflects a mix of single and double quotes.
This tutorial uses TypeScript and Lit with Umbraco, It is expected that your package is already [set up to use TypeScript and Lit](../../customizing/development-flow/vite-package-setup.md).
|
@leekelleher, could I ask you to verify the code example changes in this PR, please? @sofietoft, this PR also contains new content, so would you review that, please? |
for simplification.
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the code snippet updates. 🚀
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great 💪
Appreciate the attention to detail! ⭐
Description
UmbPropertyValueChangeEventand converts them intoUmbChangeEventwith updated code sampleslineNumbers="true"andoverflow="wrap"on large code sectionsType of suggestion
Product & version (if relevant)
15
Deadline (if relevant)
ASAP