Added configure environment section... #7012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofietoft
reviewed
Apr 7, 2025
Contributor
sofietoft
left a comment
sofietoft
left a comment
There was a problem hiding this comment.
I've added a couple of comments.
Instead of only having a heading for "Configuring an environment", wouldn't it make sense to have the following instead:
Adding an environment
Removing an environment
And these are added as subheadings to the ## Adding or Removing heading?
Co-authored-by: sofietoft <stk@umbraco.com>
Co-authored-by: sofietoft <stk@umbraco.com>
Contributor
Author
|
Thanks, @sofietoft for your review 🙌 I've incorporated your comments. Also, updated the Configuring Environments section to mention what actions are possible in that view. |
sofietoft
reviewed
Apr 7, 2025
Contributor
sofietoft
left a comment
sofietoft
left a comment
There was a problem hiding this comment.
Just one more thing, and this article is good to go 💪
sofietoft
reviewed
Apr 7, 2025
Co-authored-by: sofietoft <stk@umbraco.com>
Contributor
Author
|
Thanks for the review, @sofietoft 🙌 I've incorporated your comments and fixed a broken image filename in the Environments article. |
sofietoft
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
... and replaced environment references
Type of suggestion
Product & version (if relevant)
Cloud
Deadline (if relevant)
Anytime