-
Notifications
You must be signed in to change notification settings - Fork 811
CMS: Add new hosting in Docker documentation #7078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, @nikolajlauridsen 🙌 We will review it as soon as we can 💪 |
AndyButland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @nikolajlauridsen - I've just tweaked a few little things I thought could be slightly improved and fixed a typo or two. If you are happy with these suggestions you can accept them.
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Butland <abutland73@gmail.com>
|
Thanks Andy, it reads much better now 🎉 H5YR |
|
@nikolajlauridsen Could you please add the new article to the |
|
All done 👍 |
eshanrnh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @nikolajlauridsen 🙌 Just couple of suggestions here and there which I'll incorporate myself.
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
15/umbraco-cms/fundamentals/setup/server-setup/running-umbraco-in-docker.md
Outdated
Show resolved
Hide resolved
|
@nikolajlauridsen Can you add the updates to the rest of the versions? I'll then merge the PR once done 💪 |
|
All done 👍 |
|
Awesome, Thanks 🙌 |
Description
I've added a document about considerations when hosting Docker following this discussion on the CMS tracker: umbraco/Umbraco-CMS#18468
This is not meant to be an exhaustive guide, but rather just some thoughts about what you must be aware of when hosting Umbraco in Docker, mainly around file system limitations.
This is relevant across versions, but I've only added a V15 document for now, so we don't have to populate any corrections across multiple documents.
Type of suggestion
Product & version (if relevant)
CMS - V10 and up
Deadline (if relevant)
N/A