Skip to content

Conversation

@iOvergaard
Copy link
Contributor

Description

Added section about HMACSecretKey to secure image requests. This has been a feature since V12, so it updates all articles since then.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

13, 14, 15, 16

Deadline (if relevant)

ASAP

@iOvergaard iOvergaard requested review from Copilot and eshanrnh May 15, 2025 13:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the HMACSecretKey configuration used to secure image requests. The changes update reference articles for versions 13 through 16 by introducing the new HMACSecretKey setting and providing example configuration code and usage instructions.

  • Added HMACSecretKey setting to the JSON configuration and its documentation.
  • Included an example using the IOptions pattern with a code snippet to generate a secure random key.
  • Updated documentation across multiple version folders (13, 14, 15, 16) to reflect these changes.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
16/umbraco-cms/reference/configuration/imagingsettings.md Added HMACSecretKey setting and documentation section, including sample code.
15/umbraco-cms/reference/configuration/imagingsettings.md Added HMACSecretKey setting and documentation section, including sample code.
14/umbraco-cms/reference/configuration/imagingsettings.md Added HMACSecretKey setting and documentation section, including sample code.
13/umbraco-cms/reference/configuration/imagingsettings.md Added HMACSecretKey setting and documentation section, including sample code.
Comments suppressed due to low confidence (4)

16/umbraco-cms/reference/configuration/imagingsettings.md:87

  • [nitpick] Consider updating the header to use consistent capitalization ('HMACSecretKey') to match the configuration property.
## Hmac secret key

15/umbraco-cms/reference/configuration/imagingsettings.md:87

  • [nitpick] Consider standardizing the header text to 'HMACSecretKey' to maintain consistency with the property name.
## Hmac secret key

14/umbraco-cms/reference/configuration/imagingsettings.md:87

  • [nitpick] Update the header to 'HMACSecretKey' for consistency with the configuration property name.
## Hmac secret key

13/umbraco-cms/reference/configuration/imagingsettings.md:87

  • [nitpick] Update the header text to 'HMACSecretKey' to match the naming convention used in the configuration properties.
## Hmac secret key

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @iOvergaard 🙌 The PR looks great.

I've made some minor suggestions as per the styleguide for v13 which I'll incorporate. Can you make these changes for the rest of the versions, please?

@iOvergaard
Copy link
Contributor Author

Thanks for the PR, @iOvergaard 🙌 The PR looks great.

I've made some minor suggestions as per the styleguide for v13 which I'll incorporate. Can you make these changes for the rest of the versions, please?

Done :-)

@iOvergaard iOvergaard requested a review from eshanrnh May 16, 2025 07:06
Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks 🙌

@eshanrnh eshanrnh merged commit 38e8476 into main May 16, 2025
6 of 11 checks passed
@iOvergaard iOvergaard deleted the cms/v16/imaging-settings-hmac branch May 16, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants