-
Notifications
You must be signed in to change notification settings - Fork 811
Fixing links in umbraco 14 change docs that are pointing to 404 pages #7254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some links were pointing to 404 pages, so I updated them to the latest working versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those broken links, @sakuexe 🙌 We really appreciate it 💪
You can use these links for authProvider and mfaLoginProvider.
It would be great if you could also fix the links for v14 and v15 😊.
- fixed the link for authProvider - fixed the link for mfaProvider - updated all the 14+ versions to have the fixed urls
|
Thank you very much for the help! The links have now been updated for all the pages (v14, v15, v16) and the authProvider and mfaLoginProvider links you provided have been added. |
eshanrnh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the broken links for all versions 💪
Some links were pointing to 404 pages, so I updated them to the latest working versions.
📋 Description
This PR fixes the links that would send the user to a 404 page inside the Umbraco 14 listing on the version specific upgrades page.
Link to the page I'm talking about
Help needed
I did not figure out where the following two links should point to unfortunately. So if someone knows, please let me know so I can fix them too while I'm at it.
mfaProvider link, from here
authProvider link, from here
📎 Related Issues (if applicable)
No related issues are applicable.
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
The changes are made to the version 16 documentation. Should I also make the same changes to the two earlier versions' pages?
Deadline (if relevant)
There is no deadline, but it would be nice to fix these before the next LTS, since a lot of people will be reading through this documentation when they need to migrate from version 13.
📚 Helpful Resources