-
Notifications
You must be signed in to change notification settings - Fork 811
Updated some regex expressions to match the styleguide #7341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes look really great!
I'll be testing them out a bit tomorrow.
I'm really (probably a bit too much) excited about adding the "extensions" that ensure we can still write names with small caps when they're part of links etc.
Also the new rule about the link texts 🙏 That's a really great addition.
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the rules locally and they work great!
I couldn't, however, I had to make some changes ot the "LinkTextClarity" rule to get it working. See my comment in the file.
Co-authored-by: sofietoft <stk@umbraco.com>
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great! 👏
📋 Description
📎 Related Issues (if applicable)
NA
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Deadline (if relevant)
Anytime
📚 Helpful Resources