Skip to content
This repository was archived by the owner on Jun 18, 2018. It is now read-only.

Conversation

@kjac
Copy link

@kjac kjac commented Jul 16, 2015

This way it's easier to tell the items apart when they're all collapsed.

nc with icons

This way it's easier to tell the items apart when they're all collapsed
@mattbrailsford
Copy link
Collaborator

Initial thoughts are:

  1. Add a tiny bit more space between icon and heading
  2. Make this a prevalue config option to switch on/off

Kenn Jacobsen added 2 commits July 17, 2015 11:08
@kjac
Copy link
Author

kjac commented Jul 17, 2015

@mattbrailsford done. I don't know about the prevalue config ... do we really want to add config options for every little thing? But all the same, I added it for now and it works.

nc with icons 2

@mattbrailsford
Copy link
Collaborator

I know what you mean about config options, but when it's visual, I kinda like to have the option as not everyone will want them. That said, if we hear that every person turns them on, in the future we can just remove the config option and have them by default.

Spacing looks much better (it's the little things)

@mattbrailsford
Copy link
Collaborator

I think the prevalue should be "Show Icons" rather than "Hide Icons". Happy for it to default to true though, see core examples for how to set default value https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web/PropertyEditors/ContentPickerPropertyEditor.cs

@kjac
Copy link
Author

kjac commented Jul 20, 2015

Aite... I just made it "hide icons" because there is a "hide label" too... trying to get less boolean confuzzlement :) but no problem, I'll look at it.

@kjac
Copy link
Author

kjac commented Jul 20, 2015

Done - "hide icons" is now "show icons".

Note that this PR now also fixes the default value for "confirm deletes" (which should be a string value, not an integer).

mattbrailsford added a commit that referenced this pull request Jul 22, 2015
Add document type icons to the items
@mattbrailsford mattbrailsford merged commit e275431 into umco:develop Jul 22, 2015
@leekelleher leekelleher added this to the 0.2.0 milestone Jul 22, 2015
@leekelleher
Copy link
Collaborator

Thanks @kjac - looks great!

@kjac
Copy link
Author

kjac commented Jul 22, 2015

You're welcome :-)
On Jul 22, 2015 4:42 PM, "Lee Kelleher" notifications@github.com wrote:

Thanks @kjac https://github.com/kjac - looks great!


Reply to this email directly or view it on GitHub
#21 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants