Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

Conversation

@skttl
Copy link
Owner

@skttl skttl commented Oct 2, 2019

Note: This is not compatible with any released Umbraco version, as there is a bug in the DeleteVersion and DeleteVersions methods in the Content Service. There is a PR for this bug here: umbraco/Umbraco-CMS#6543

I updated the packages, and rewrote the service to use the content service instead of raw sql. And then I made it use DI, to inject the config and the UnVersionService.

@leekelleher leekelleher mentioned this pull request Oct 3, 2019
@enkelmedia
Copy link

I managed to miss that there was work in progress for V8 so I started out with my own branch,

#21

One thing that I do differently is that I'm not using the core-version of "DeleteVersions" but looking at a list of versions, this solution would run on 8.0 as well - but I guess that it would not be as fast if there is a lot of versions on the first Save.

One good thing with this approach is that I've added some unit tests to test the logic for how we figure out what versions to delete.

I guess that the best way forward is to decided which of our branches to focus on and then continue the work from there?

Let me know if I can do anything more to help!

@skttl
Copy link
Owner Author

skttl commented Dec 13, 2019

I think the DeleteVersion method is also broken pre 8.4 (haven't tested in a while though), so maybe it's not that important to get Unversion working for earlier versions - unless we want to keep using SQL?

I like that you added tests, I'm not doing TDD myself, but I guess that is what the cool kids are doing 😜

Besides @leekelleher / @mattbrailsford hasn't been very clear on their intentions for the package, they should probably have a say :). I would be happy to take over, like with DTGE, if that is what it takes.

# Conflicts:
#	src/Our.Umbraco.UnVersion.sln
#	src/Our.Umbraco.UnVersion/Bootstrap.cs
#	src/Our.Umbraco.UnVersion/Our.Umbraco.UnVersion.csproj
#	src/Our.Umbraco.UnVersion/Services/UnVersionService.cs
#	src/Our.Umbraco.UnVersion/UnVersionComponent.cs
#	src/Our.Umbraco.UnVersion/UnVersionConfig.cs
#	src/Our.Umbraco.UnVersion/packages.config
@skttl skttl merged commit 020cb1b into skttl:develop Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants