-
Notifications
You must be signed in to change notification settings - Fork 10
Port to v8 #20
Port to v8 #20
Conversation
|
I managed to miss that there was work in progress for V8 so I started out with my own branch, One thing that I do differently is that I'm not using the core-version of "DeleteVersions" but looking at a list of versions, this solution would run on 8.0 as well - but I guess that it would not be as fast if there is a lot of versions on the first Save. One good thing with this approach is that I've added some unit tests to test the logic for how we figure out what versions to delete. I guess that the best way forward is to decided which of our branches to focus on and then continue the work from there? Let me know if I can do anything more to help! |
|
I think the I like that you added tests, I'm not doing TDD myself, but I guess that is what the cool kids are doing 😜 Besides @leekelleher / @mattbrailsford hasn't been very clear on their intentions for the package, they should probably have a say :). I would be happy to take over, like with DTGE, if that is what it takes. |
# Conflicts: # src/Our.Umbraco.UnVersion.sln # src/Our.Umbraco.UnVersion/Bootstrap.cs # src/Our.Umbraco.UnVersion/Our.Umbraco.UnVersion.csproj # src/Our.Umbraco.UnVersion/Services/UnVersionService.cs # src/Our.Umbraco.UnVersion/UnVersionComponent.cs # src/Our.Umbraco.UnVersion/UnVersionConfig.cs # src/Our.Umbraco.UnVersion/packages.config
…, which UnVersion relies on)
Note: This is not compatible with any released Umbraco version, as there is a bug in the DeleteVersion and DeleteVersions methods in the Content Service. There is a PR for this bug here: umbraco/Umbraco-CMS#6543
I updated the packages, and rewrote the service to use the content service instead of raw sql. And then I made it use DI, to inject the config and the UnVersionService.