Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] block support add from a npm package #2646

Closed
4 tasks done
yutingzhao1991 opened this issue Jun 19, 2019 · 4 comments
Closed
4 tasks done

[Feature Request] block support add from a npm package #2646

yutingzhao1991 opened this issue Jun 19, 2019 · 4 comments

Comments

@yutingzhao1991
Copy link
Contributor

Background

当前区块只支持从 git 来源,有一些缺陷,见 umijs/umi-blocks#37 (comment)

好处:

坏处:

  • 多一步发布过程。

Proposal

支持从 npm 包添加区块

Additional context

比如:

umi block add a-block-npm-package
@sorrycc
Copy link
Member

sorrycc commented Jun 20, 2019

我倾向继续用 Github 的方式,除了不用发布,还有是做集中管理,切 npm 之后后面想收就收不回来了。慢的问题想办法做优化,比如有更新时才拉取,这样会在第一次慢,后面都免了请求的步骤,甚至我们自己搭一个缓存了 git 的服务。

@afc163
Copy link
Contributor

afc163 commented Jun 20, 2019

主要是国内的网络环境太差,目前看来不是缓存不缓存的问题,而是第一次太慢而且无法成功完成的问题。

#4550

@afc163
Copy link
Contributor

afc163 commented Jun 20, 2019

或者可以试试读取 https://github.com.cnpmjs.org/

@yutingzhao1991
Copy link
Contributor Author

速度的问题解决了我觉得这个没什么必要再做了

@sorrycc sorrycc closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants