This repository was archived by the owner on Aug 2, 2022. It is now read-only.
add method to handle channels as time #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChristianBeilschmidt
left a comment
ChristianBeilschmidt
left a comment
There was a problem hiding this comment.
It looks somewhat fine, although a very hacky solution.
The system ignores the previously set channel.
How does the system handle channel = 0?
|
|
||
| Log::debug(concat("getDataLoadingInfo: using channels as time")); | ||
|
|
||
| auto time_channel = 0; |
Member
There was a problem hiding this comment.
What happens if time is too small and channel stays zero?
Contributor
Author
There was a problem hiding this comment.
i have added a NoRasterForGivenTimeException
src/util/gdal_timesnap.cpp
Outdated
Comment on lines
225
to
227
| auto channel_time_strings = datasetJson.get("channel_start_time_list", Json::Value(Json::ValueType::arrayValue)); | ||
| for (auto &time_string : channel_time_strings) { | ||
| auto channel_time = timeParser->parse(time_string.asString()); |
Member
There was a problem hiding this comment.
Suggested change
| auto channel_time_strings = datasetJson.get("channel_start_time_list", Json::Value(Json::ValueType::arrayValue)); | |
| for (auto &time_string : channel_time_strings) { | |
| auto channel_time = timeParser->parse(time_string.asString()); | |
| const auto channel_time_strings = datasetJson.get("channel_start_time_list", Json::Value(Json::ValueType::arrayValue)); | |
| for (const auto &time_string : channel_time_strings) { | |
| const auto channel_time = timeParser->parse(time_string.asString()); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.