Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project missing agent.template.yml which is required for Docker build #201

Closed
jballment opened this issue Jul 22, 2024 · 1 comment · Fixed by #205
Closed

Project missing agent.template.yml which is required for Docker build #201

jballment opened this issue Jul 22, 2024 · 1 comment · Fixed by #205

Comments

@jballment
Copy link
Contributor

Describe the bug
Getting the following error message when build docker image as per https://github.com/uncefact/project-vckit/blob/next/README.md:

docker build -t vckit-api .

ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref 8e07bce4-229d-48aa-98bd-54c87e23d344::zrthlfvwg3pjmeotvn8ueysab: "/agent.template.yml": not found

To Reproduce
Steps to reproduce the behavior:

  1. From within WSL using Ubuntu 22.04 image
  2. git clone https://github.com/uncefact/project-vckit.git
  3. cd project-vckit.git
  4. docker build -t vckit-api .
  5. See error

Expected behavior
It looks like the Dockerfile is trying to copy agent.template.yml from the project into the docker image but the template is missing. Expect that the agent.template.yml be included as part of the git repository or give a mechanism to build the agent.yml from Docker.

Desktop (please complete the following information):

  • OS: Windows 10, WSL Ubuntu 22.04 LTS image
@jballment
Copy link
Contributor Author

jballment commented Jul 23, 2024

I've also noted that the current docker-compose.yaml file build a postgresql container for vckit but without the parameterised agent.template.yml file, vckit will default to a sqlite database. Even the build command in README.md shows building docker with postgres arguments which will not have any effect until the agent.template is added to the project.

jballment added a commit to BizCubedPtyLtd/project-vckit that referenced this issue Jul 23, 2024
jballment added a commit to BizCubedPtyLtd/project-vckit that referenced this issue Jul 23, 2024
namhoang1604 added a commit that referenced this issue Jul 24, 2024
## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [ #201  ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Description
Updated Dockerfile to use agent.template.xml from packages/cli/default/
so that running "docker compose up --build" works out of the box.

## Related Tickets & Documents

Fixes #201 

## Mobile & Desktop Screenshots/Recordings
N/A

## Added tests?

- [ X ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

## Added to documentation?

- [ ] 📜 README.md
- [ ] 📓 [vc-kit doc site](https://uncefact.github.io/vckit/)
- [ ] 📕 storybook
- [ X ] 🙅 no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?


<!-- note: PRs with deleted sections will be marked invalid -->

Co-authored-by: Nam Hoang <hoangxuannam160493@gmail.com>
namhoang1604 added a commit that referenced this issue Sep 19, 2024
…erge-next-to-main

* 'next' of github.com:uncefact/project-vckit: (90 commits)
  feat: enveloping proof (#207)
  feat: Add `eddsa-rdfc-2022-cryptosuite` Plugin (#200)
  chore: update bitstring status package (#211)
  docs: update identifier creation (#208)
  feat(cd): ghcr.io setup and docker image build workflow (#206)
  changed Dockerfile to use default agent.template.yml (#201) (#205)
  parameterised API Key for Docker builds (#203) (#204)
  feat: setup package workflow
  feat: create git workflow for release tagging and generate the release note (#199)
  fix: Provide meaningful error message when signature verification fails (#197)
  docs: add documentation site (#198)
  feat: implement renderer 2024 provider (#177)
  chore: update arguments and envs for the Dockerfile (#194)
  fix: using revocation list on explorer and handle no hash (#192)
  docs: add yarn to prerequisites
  chore: change node version to 20.12.2 (#187)
  chore: update default agent for Status plugin (#186)
  chore: fix the dockerfile to set entrypoint
  chore: update vckit Dockerfile (#184)
  chore: update DockerFile and agent template (#183)
  ...

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>

# Conflicts:
#	.github/workflows/build-test-publish.yml
#	.github/workflows/deploy-to-s3.yml
#	jest.config.mjs
#	package.json
#	packages/core-types/package.json
#	packages/credential-oa/__tests__/action-handler.test.ts
#	packages/credential-oa/src/action-handler.ts
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant