-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enveloping proof #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦roject-vckit into feat/enveloping_proof
namhoang1604
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ldhyen99 please review your code again. That must use the JsonWebKey
not JsonWebKey2020
packages/credential-jwt-enveloping-proof/src/suite/VCkitJsonWebKey.ts
Outdated
Show resolved
Hide resolved
packages/credential-jwt-enveloping-proof/src/suite/VCkitJsonWebKey.ts
Outdated
Show resolved
Hide resolved
β¦ckit into feat/enveloping_proof
β¦ckit into feat/enveloping_proof
namhoang1604
previously approved these changes
Sep 13, 2024
namhoang1604
approved these changes
Sep 13, 2024
namhoang1604
added a commit
that referenced
this pull request
Sep 19, 2024
β¦erge-next-to-main * 'next' of github.com:uncefact/project-vckit: (90 commits) feat: enveloping proof (#207) feat: Add `eddsa-rdfc-2022-cryptosuite` Plugin (#200) chore: update bitstring status package (#211) docs: update identifier creation (#208) feat(cd): ghcr.io setup and docker image build workflow (#206) changed Dockerfile to use default agent.template.yml (#201) (#205) parameterised API Key for Docker builds (#203) (#204) feat: setup package workflow feat: create git workflow for release tagging and generate the release note (#199) fix: Provide meaningful error message when signature verification fails (#197) docs: add documentation site (#198) feat: implement renderer 2024 provider (#177) chore: update arguments and envs for the Dockerfile (#194) fix: using revocation list on explorer and handle no hash (#192) docs: add yarn to prerequisites chore: change node version to 20.12.2 (#187) chore: update default agent for Status plugin (#186) chore: fix the dockerfile to set entrypoint chore: update vckit Dockerfile (#184) chore: update DockerFile and agent template (#183) ... Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com> # Conflicts: # .github/workflows/build-test-publish.yml # .github/workflows/deploy-to-s3.yml # jest.config.mjs # package.json # packages/core-types/package.json # packages/credential-oa/__tests__/action-handler.test.ts # packages/credential-oa/src/action-handler.ts # pnpm-lock.yaml
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Note:
Setup:
pnpm build-clean
before startpostinstall
ofpackage.json
file, change togit pull --depth=1 origin feat/enveloping_proof
pnpm install
&pnpm run build
&pnpm vckit config
Step for testing Enveloping proof:
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?