Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add eddsa-rdfc-2022-cryptosuite Plugin #200

Merged
merged 29 commits into from
Sep 12, 2024
Merged

Feat: Add eddsa-rdfc-2022-cryptosuite Plugin #200

merged 29 commits into from
Sep 12, 2024

Conversation

huynguyen-hl
Copy link
Collaborator

@huynguyen-hl huynguyen-hl commented Jul 21, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

Issue a V1 VCDM with DataIntegrityProof:

image

Verify the DataIntegrityProof V1 VCDM:

image

Issue a V2 VCDM with DataIntegrityProof:

image

Verify the DataIntegrityProof V2 VCDM:

image

Related Tickets & Documents

https://github.com/gs-gs/fa-ag-trace/issues/495

Declare the plugin in your Veramo agent:

# W3C credentialPlugin
credentialIssuerLD:
  $require: '@veramo/credential-ld#CredentialIssuerLD'
  $args:
    - suites:
        - $require: '@vckit/credential-data-integrity#VCkitEddsaRdfc2022'
        #  others should be included here
      contextMaps:
        - $require: '@vckit/credential-data-integrity?t=object#contexts'
        - $require: '@veramo/credential-ld?t=object#LdDefaultContexts'
        - $require: '@transmute/credentials-context?t=object#contexts'
        - $require: '@transmute/did-context?t=object#contexts'
        #  others should be included here

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 vc-kit doc site
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@huynguyen-hl huynguyen-hl changed the title Feat: Add credential-data-integrity plugin package Feat: Add eddsa-rdfc-2022-cryptosuite Plugin Jul 21, 2024
@ashleythedeveloper
Copy link
Contributor

Test

namhoang1604
namhoang1604 requested changes Jul 25, 2024
View reviewed changes
packages/bitstringStatusList/src/bitstring-status-list-status.ts Outdated Show resolved Hide resolved
packages/cli/default/agent.template.yml Outdated Show resolved Hide resolved
packages/cli/default/agent.template.yml Outdated Show resolved Hide resolved
packages/cli/default/default-dev.yml Outdated Show resolved Hide resolved
packages/cli/default/default-dev.yml Outdated Show resolved Hide resolved
packages/credential-data-integrity/__tests__/VCkitEddsaRdfc2022.test.ts Outdated Show resolved Hide resolved
packages/credential-data-integrity/package.json Outdated Show resolved Hide resolved
packages/credential-data-integrity/src/suites/VCkitEddsaRdfc2022.ts Outdated Show resolved Hide resolved
packages/credential-data-integrity/src/suites/VCkitEddsaRdfc2022.ts Outdated Show resolved Hide resolved
packages/revocation-list-2020/src/revocation-list-2020-status.ts Outdated Show resolved Hide resolved
@huynguyen-hl
chore: remove unnecessary code and update documentation
a23bebc
@huynguyen-hl
test: add some test cases for VCkitEddsaRdfc2022 signature
c3be19b
@huynguyen-hl
Merge branch 'next' into feat/crypto-suite-plugin
18fe79e
@huynguyen-hl
chore: remove unnecessary code
50d9137
@huynguyen-hl
chore: remove unnecessary code
527b2e4
@huynguyen-hl
chore: update agant template files
9db0212
@huynguyen-hl
docs: update README for credential-data-integrity package
b46d68f
@huynguyen-hl
chore: remove unit tests for the VCkitEddsaRdfc2022 suite
817de21
@huynguyen-hl
chore: remove unnecessary code
526de06
@huynguyen-hl
chore: remove check Coverage in the workflow
4d71c96
@huynguyen-hl
chore: revert build-and-test.yml workflow
cc9ab8d
@huynguyen-hl
chore: update EddsaRdfc2022's preDidResolutionModification method and…
76ea059 
… the web did doc router
@huynguyen-hl
chore: remove JsonWebKey in web did doc router
7ca878d
@huynguyen-hl
chore: update agent template files
1e8d774
@huynguyen-hl
chore: revert web-did-doc-router.ts file
a519ddd
@huynguyen-hl
docs: update credential data integrity documents
de8b22c
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 46.391752577319586%

St.❔
 Category Percentage Covered / Total
🔴 Statements 46.39% 90/194
🔴 Branches 0% 0/1
🔴 Functions 0% 0/7
🔴 Lines 46.39% 90/194

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 97bc215

namhoang1604
namhoang1604 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhoang1604 namhoang1604 merged commit d651176 into next Sep 12, 2024
@namhoang1604 namhoang1604 deleted the feat/crypto-suite-plugin branch September 12, 2024 08:48
namhoang1604 added a commit that referenced this pull request Sep 19, 2024
@namhoang1604
Merge branch 'next' of github.com:uncefact/project-vckit into chore/m…
430c891 
…erge-next-to-main

* 'next' of github.com:uncefact/project-vckit: (90 commits)
  feat: enveloping proof (#207)
  feat: Add `eddsa-rdfc-2022-cryptosuite` Plugin (#200)
  chore: update bitstring status package (#211)
  docs: update identifier creation (#208)
  feat(cd): ghcr.io setup and docker image build workflow (#206)
  changed Dockerfile to use default agent.template.yml (#201) (#205)
  parameterised API Key for Docker builds (#203) (#204)
  feat: setup package workflow
  feat: create git workflow for release tagging and generate the release note (#199)
  fix: Provide meaningful error message when signature verification fails (#197)
  docs: add documentation site (#198)
  feat: implement renderer 2024 provider (#177)
  chore: update arguments and envs for the Dockerfile (#194)
  fix: using revocation list on explorer and handle no hash (#192)
  docs: add yarn to prerequisites
  chore: change node version to 20.12.2 (#187)
  chore: update default agent for Status plugin (#186)
  chore: fix the dockerfile to set entrypoint
  chore: update vckit Dockerfile (#184)
  chore: update DockerFile and agent template (#183)
  ...

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>

# Conflicts:
#	.github/workflows/build-test-publish.yml
#	.github/workflows/deploy-to-s3.yml
#	jest.config.mjs
#	package.json
#	packages/core-types/package.json
#	packages/credential-oa/__tests__/action-handler.test.ts
#	packages/credential-oa/src/action-handler.ts
#	pnpm-lock.yaml
@ldhyen99 ldhyen99 mentioned this pull request Jan 3, 2025
Merged
This was referenced Jan 17, 2025
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhoang1604 namhoang1604 namhoang1604 approved these changes

@ldhyen99 ldhyen99 Awaiting requested review from ldhyen99

@hoa-ngo-gs hoa-ngo-gs Awaiting requested review from hoa-ngo-gs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huynguyen-hl @ashleythedeveloper @namhoang1604