Skip to content

UNDERTOW-1770 HttpString uses obsolete String Constructor #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2020
Merged

UNDERTOW-1770 HttpString uses obsolete String Constructor #925

merged 2 commits into from
Sep 13, 2020

Conversation

gorky
Copy link
Contributor

@gorky gorky commented Aug 18, 2020

@gorky
Copy link
Contributor Author

gorky commented Aug 18, 2020

Seems we have some intermittent/unrelated failures with IO?

[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.312 s <<< FAILURE! - in io.undertow.server.handlers.SenderTestCase
[ERROR] testAsyncTransfer[proxy][http2](io.undertow.server.handlers.SenderTestCase)  Time elapsed: 0.246 s  <<< ERROR!
org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 6,706,000; received: 4,489,206)

[ERROR] Errors: 
[ERROR]   ServletInputStreamSSLTestCase>AbstractServletInputStreamTestCase.testAsyncServletInputStreamInParallel:120->AbstractServletInputStreamTestCase.runTestParallel:293 » Execution

stuartwdouglas
stuartwdouglas reviewed Aug 18, 2020
View reviewed changes
core/src/main/java/io/undertow/util/HttpString.java Outdated
public String toString() {
if (string == null) {
string = new String(bytes, 0);
string = new String(bytes, java.nio.charset.Charset.forName("ISO-8859-1"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be java.nio.charset.StandardCharsets#US_ASCII

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it & thanks! I will admit I was guessing on the first character translation attempt. I've pushed a patch (and updated my Updater) with this information.

@gorky
UNDERTOW-1770 HttpString uses obsolete String Constructor
ae85689 
https://issues.redhat.com/browse/UNDERTOW-1770
Per Stuart Douglas, should be US_ASCII
undertow-io#925 (comment)

Signed-off-by: Steve Davidson <steve@j2eeguys.com>
@gorky gorky mentioned this pull request Aug 19, 2020
Merged
@fl4via fl4via added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) labels Sep 13, 2020
@fl4via fl4via merged commit 6337a0e into undertow-io:master Sep 13, 2020
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stuartwdouglas stuartwdouglas stuartwdouglas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Enhances existing behaviour or code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gorky @stuartwdouglas @fl4via