key add/list api calls #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @vitaly4uk. Thanks for your PR! Could you please add tests such that the test code coverage either remains the same or increases? The coveralls check above should indicate when that bar has been reached. |
ethantkoenig
suggested changes
Feb 7, 2017
|
|
||
|
|
||
| class GogsKey(object): | ||
|
|
Contributor
There was a problem hiding this comment.
Could you add a docstring for the GogsKey class? Also, I would prefer the name GogsPublicKey because it seems more specific.
gogs_client/interface.py
Outdated
| If no user is specified, uses user authenticated by ``auth``. | ||
| :param auth.Authentication auth: authentication for user to retrieve. | ||
| :param entities.GogsKey key: new key |
Contributor
There was a problem hiding this comment.
entities.GogsKey -> GogsKey for consistency's sake
* delete_key method have been added to api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.