Skip to content

Conversation

@guyzmo
Copy link
Contributor

@guyzmo guyzmo commented May 4, 2017

  • makes it possible to access entity.json where entity is any gogs_client.entity.*, so it's possible to introspect whethere there's any missing property to be exposed ;
  • adds default_branch as entity to be exposed.

@guyzmo guyzmo force-pushed the features/store_json_data branch 2 times, most recently from 1c7b4de to 94f9aaa Compare May 4, 2017 13:52
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
@guyzmo guyzmo force-pushed the features/store_json_data branch from 94f9aaa to 6ae13ca Compare May 4, 2017 14:00
@coveralls
Copy link

coveralls commented May 4, 2017

Coverage Status

Coverage decreased (-0.02%) to 94.0% when pulling 6ae13ca on guyzmo:features/store_json_data into 6fd4bf2 on unfoldingWord-dev:master.

@jag3773
Copy link
Contributor

jag3773 commented May 4, 2017

@guyzmo Thanks! @ethantkoenig will do a code review soon, in the meantime can you augment the tests to maintain or increase the test code coverage?

@ethantkoenig
Copy link
Contributor

@guyzmo Sorry, I accidentally reviewed #9 before this PR, not realizing that it contained all of these changes. Please refer to #9 for my feedback on these changes.

@guyzmo
Copy link
Contributor Author

guyzmo commented May 4, 2017

I'm fine with that, let's stick with the other PR ☺

@guyzmo guyzmo closed this May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants