-
Notifications
You must be signed in to change notification settings - Fork 0
Add canvas support #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6 +/- ##
===========================================
+ Coverage 94.31% 94.37% +0.05%
===========================================
Files 4 5 +1
Lines 352 391 +39
Branches 39 41 +2
===========================================
+ Hits 332 369 +37
- Misses 14 15 +1
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saxix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add human readable summary of the feature in the PR. what is the feature that we are adding from the "business/client/utiliser" point of view
Add possibility to create signatures from CeleryTaskModel instance.
Right now jobs created by inheriting CeleryTaskModel can be used in pretty simple scenarios. There is number of primitives in Celery that allow running tasks in sequence or in parallel:
But in order to use them we need a support for signatures. A signature is a representation of a task that can be passed around. Though we can still create signatures from the raw Celery tasks, we loose connection between CeleryTaskModel and it's underlying task.
This feature allows generation of signatures from CeleryTaskModel. Those signatures contain not only information required for task execution, but also information required to update CeleryTaskModel status