Initial release of generate-certs module #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
generate-certs/main.tf
Outdated
Contributor
Author
There was a problem hiding this comment.
noticing a number of these items for the iam instance profiles. There has to be a cleaner way to de-dup this.
yuhunglin
force-pushed
the
yl-generate-certs
branch
from
73e5940 to
dd60da1
Compare
generate-certs/main.tf
Outdated
Contributor
Author
There was a problem hiding this comment.
kept it simple, since this node doesn't need to be in a vpc, or event an ec2 node for that matter 🙊
Member
|
LGTM |
Member
|
Well, one point. Since we did just merge a PR with Unif.io standardization, you could scrub for that. |
Contributor
Author
|
👌 |
yuhunglin
force-pushed
the
yl-generate-certs
branch
from
dd60da1 to
c6bfd30
Compare
Initial release of `generate-certs` module: * Most options are still in terraform, for now. * Could probably figure out a way to leverage the outputs a little bit.
yuhunglin
force-pushed
the
yl-generate-certs
branch
from
c6bfd30 to
b53c5c0
Compare
yuhunglin
pushed a commit
that referenced
this pull request
Apr 5, 2018
Adding CRL verify to server.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial release of
generate-certsmodule: