Skip to content

Missing types in counterparty and wrong type on transaction.created webhook event #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Missing types in counterparty and wrong type on transaction.created webhook event #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31438e4
Missing types in counterparty and wrong type on transaction.created w…
ilyamerman Apr 7, 2022
9809d68
lint
ilyamerman Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions types/counterparty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,16 @@ export interface CreateCounterpartyWithoutTokenRequest {
* Either Business, Person or Unknown.
*/
type: "Business" | "Person" | "Unknown"

/**
* See [Tags](https://developers.unit.co/#tags).
*/
tags?: object

/**
* See [Idempotency.](https://developers.unit.co/#intro-idempotency)
*/
idempotencyKey?: string
}

relationships: {
Expand Down Expand Up @@ -130,6 +140,16 @@ export interface CreateCounterpartyWithTokenRequest {
* Either Business, Person or Unknown.
*/
type: "Business" | "Person" | "Unknown"

/**
* See [Tags](https://developers.unit.co/#tags).
*/
tags?: object

/**
* See [Idempotency.](https://developers.unit.co/#intro-idempotency)
*/
idempotencyKey?: string
}

relationships: {
Expand All @@ -152,6 +172,16 @@ export interface PatchCounterpartyRequest {
* Optional, default to false. Verify the name of the counterparty, if the name verification fails the request will fail with code field set to NameVerificationFailed.
*/
verifyName?: boolean

/**
* Optional, custom counterparty permissions. Either CreditOnly, DebitOnly, CreditAndDebit
*/
permissions?: "CreditOnly" | "DebitOnly" | "CreditAndDebit"

/**
* See [Tags](https://developers.unit.co/#tags).
*/
tags?: object
}

export interface CounterpartyBalance {
Expand Down
2 changes: 1 addition & 1 deletion types/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export type TransactionCreated = BaseEvent & {
attributes: {
summary: string
direction: "Credit" | "Debit"
amount: string
amount: number
}
relationships: {
transaction: Relationship
Expand Down