Application documents #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Customer methods in resources username removed from authorizedUser DepsitAccount was added
every resource extends this class now.
created PatchCustomerRequest interface added default content-type to header
and small refactoring
Elroie
requested changes
May 26, 2021
resources/application.ts
Outdated
|
|
||
| return res | ||
| } | ||
| // var data = new FormData() |
resources/application.ts
Outdated
| } | ||
|
|
||
| var path = `${this.basePath + this.resourcePath}/${id}` | ||
| public async listDocuments(id: number): Promise<UnitResponse<ApplicationDocument[]> | UnitError> { |
Contributor
There was a problem hiding this comment.
its not just an id its an applicationId
Suggested change
| public async listDocuments(id: number): Promise<UnitResponse<ApplicationDocument[]> | UnitError> { | |
| public async listDocuments(applicationId: number: number): Promise<UnitResponse<ApplicationDocument[]> | UnitError> { |
resources/baseResource.ts
Outdated
| } | ||
|
|
||
|
|
||
| // export async function delete(){ |
Contributor
There was a problem hiding this comment.
remove until you will implement it
types/core.ts
Outdated
| }] | ||
| } | ||
|
|
||
| export function createAddress(street: string, city: string, postalCode: string, country: string, state?: State, street2?: string): Address { |
Contributor
There was a problem hiding this comment.
add the rest of the creational functions (e.g. createFullName etc)
factory methods were completed added httpDelete for future use id renamed to customerId or applicationId
Elroie
approved these changes
May 27, 2021
ilyamerman
pushed a commit
that referenced
this pull request
Jan 6, 2022
YegorZh
pushed a commit
to YegorZh/unit-node-sdk
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Customer interface in core
added Customer methods in resources
username removed from authorizedUser
added baseResource class, every resource extends this class now.
created types/depositAccount.ts
created PatchCustomerRequest interfaces