-
Notifications
You must be signed in to change notification settings - Fork 1
Features/ci integration #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… against feature branches temporarily.
…. Environment variables will be set by AWS ECS and at container startup they will be injected into the application using a sequence of scripts integrated in the Dockerfile. This can be tested locally by using a .env.docker.local file in the .env folder and then building and running the docker image locally. This setup will allow the continued normal development using the npm run dev command. Stateful build information has been removed from the package.json as well as the corresponding .env files that are no longer necessary.
|
@rtapella I've pushed modifications in support of environment variable injection so that when marketplace stands up the UI, it can inject configuration information into the application (e.g. WPST URL, Cognito URLs, etc.). Luckily I was also able to figure out how to retain the normal development tooling using the typical Can you please review again when you have a chance so that we can cut a release. I'll have to circle back and add documentation to the README. |
# Conflicts: # CHANGELOG.md
rtapella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm
Purpose
Add CI/CD to the unity-ui application to build the application as a container.
Note: Additional work is still needed to resolve SSM param integration. This ticket was to get the CI/CD functional.
Proposed Changes
Issues
Testing
docker runarguments which models how AWS ECS will also inject ENV vars