Skip to content

Conversation

RedlineTriad
Copy link
Member

Purpose

Implements/Fixes #1252

Open Questions and Pre-Merge TODOs

  • This fix is tested on the same branch it is PR'ed to.
  • I correctly commented my code
  • My code is indented with tabs and not spaces
  • This PR does not include any unnecessary .meta, .prefab or .unity (scene) changes
  • This PR does not bring up any new compile errors
  • This PR has been tested in editor
  • This PR has been tested in multiplayer

@DooblyNoobly DooblyNoobly added the Status: DNM "Do Not Merge". Don't merge this Pull Request, as changes where requor further additions are needed. label Dec 15, 2018
@DooblyNoobly
Copy link
Member

just let me know when this is ready for review/merge

@fomalsd fomalsd removed the Status: DNM "Do Not Merge". Don't merge this Pull Request, as changes where requor further additions are needed. label Dec 16, 2018
Copy link
Contributor

@fomalsd fomalsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
Wasn't aware that you could do multiple clauses in ternary operation :)
I believe FPS counter should be a Mathf.Floored integer – there isn't much purpose for that decimal, and it takes a bit of extra space.
Also because it gets updated every frame it strobes really fast and that makes it hard to read – please consider making readings once every half second or so.
Code looks very clean – keep it up! Just address these two things and it would be perfect

Copy link
Contributor

@fomalsd fomalsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good :)

@fomalsd fomalsd merged commit fe82cd1 into unitystation:develop Dec 16, 2018
@RedlineTriad RedlineTriad deleted the FPS_Display branch December 16, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FPS-Counter to the debug menu

3 participants