MCP register tools #57

AndreiGS · 2025-08-31T17:34:59Z

MCP tools were registered as a single tool instead of "recursively" registering MCP server internal tools
Plugin logs were not showing

Summary by cubic

Fixes MCP tool registration by expanding and registering each MCP server tool instead of a single wrapper. Restores plugin logs by adding default stderr logging across communication protocols.

Bug Fixes
- Recursively register MCP server tools when an MCP manual is referenced, keeping the "." name prefix.
- More robust MCP sessions: reuse existing sessions, retry on session-level errors, and clean up on deregister/close.
Logging
- Add a default INFO-level StreamHandler to all protocol plugins when no handlers are configured, so logs show by default.
- Normalize MCP logs via lightweight helper methods.

cubic-dev-ai

15 issues found across 9 files

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

plugins/communication_protocols/http/src/utcp_http/http_communication_protocol.py

plugins/communication_protocols/http/src/utcp_http/sse_communication_protocol.py

plugins/communication_protocols/socket/src/utcp_socket/tcp_communication_protocol.py

plugins/communication_protocols/gql/src/utcp_gql/gql_communication_protocol.py

plugins/communication_protocols/mcp/src/utcp_mcp/mcp_communication_protocol.py

…ication_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

…cation_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

…tion_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

…ication_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

core/src/utcp/implementations/utcp_client_implementation.py

plugins/communication_protocols/http/src/utcp_http/streamable_http_communication_protocol.py

h3xxit · 2025-09-02T12:39:56Z

Btw, after changing that, try running utcp-agent with playwright MCP. And see if browser searching works. That's the goal.

h3xxit · 2025-09-04T16:19:53Z

@cubic-dev-ai review

cubic-dev-ai · 2025-09-04T16:20:09Z

@cubic-dev-ai review

@h3xxit I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai

7 issues found across 12 files

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

cubic-dev-ai · 2025-09-04T16:36:55Z

plugins/communication_protocols/mcp/src/utcp_mcp/mcp_communication_protocol.py

+
+        if "." not in tool_name:
+            is_resource, name = self._is_resource(tool_name)
+            server_name, target_resource = normalize(await self._get_tool_server(name, tool_call_template) if not is_resource else await self._get_resource_server(name, tool_call_template))


Fully qualified tool names parse the server but then ignore it, re-searching all servers; this can call the wrong server or fail when a specific server was requested.

Prompt for AI agents

Address the following comment on plugins/communication_protocols/mcp/src/utcp_mcp/mcp_communication_protocol.py at line 308: <comment>Fully qualified tool names parse the server but then ignore it, re-searching all servers; this can call the wrong server or fail when a specific server was requested.</comment> <file context> @@ -260,59 +257,148 @@ async def call_tool(self, caller: 'UtcpClient', tool_name: str, tool_args: Dict[ + + if "." not in tool_name: + is_resource, name = self._is_resource(tool_name) + server_name, target_resource = normalize(await self._get_tool_server(name, tool_call_template) if not is_resource else await self._get_resource_server(name, tool_call_template)) + return McpCommunicationProtocol._ParseToolResult(None, server_name, name, is_resource, target_resource) + </file context>

cubic-dev-ai · 2025-09-04T16:36:55Z

plugins/communication_protocols/gql/src/utcp_gql/gql_communication_protocol.py

+if not logger.hasHandlers():  # Only add default handler if user didn't configure logging
+    handler = logging.StreamHandler(sys.stderr)
+    handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s"))
+    logger.addHandler(handler)


Adding a handler without disabling propagation can cause duplicate log records if root/global handlers are configured later; set propagate=False after adding the default handler.

(Based on your team's feedback about plugin logs not showing by default, this keeps the default handler while preventing duplicates when applications also configure logging.)

Prompt for AI agents

Address the following comment on plugins/communication_protocols/gql/src/utcp_gql/gql_communication_protocol.py at line 19: <comment>Adding a handler without disabling propagation can cause duplicate log records if root/global handlers are configured later; set propagate=False after adding the default handler. (Based on your team's feedback about plugin logs not showing by default, this keeps the default handler while preventing duplicates when applications also configure logging.)</comment> <file context> @@ -12,6 +13,13 @@ +if not logger.hasHandlers(): # Only add default handler if user didn't configure logging + handler = logging.StreamHandler(sys.stderr) + handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s")) + logger.addHandler(handler) + logger.setLevel(logging.INFO) + </file context>

Suggested change

logger.addHandler(handler)

logger.addHandler(handler); logger.propagate = False

cubic-dev-ai · 2025-09-04T16:36:56Z

plugins/communication_protocols/socket/src/utcp_socket/tcp_communication_protocol.py

+if not logger.hasHandlers():  # Only add default handler if user didn't configure logging
+    handler = logging.StreamHandler(sys.stderr)
+    handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s"))
+    logger.addHandler(handler)


Adding a handler without disabling propagation can cause duplicate logs when global handlers are configured later; set logger.propagate = False when installing the default handler.

(Based on your team's feedback about restoring plugin logs by default; this keeps logs visible without duplicating them when global logging is configured.)

Prompt for AI agents

Address the following comment on plugins/communication_protocols/socket/src/utcp_socket/tcp_communication_protocol.py at line 23: <comment>Adding a handler without disabling propagation can cause duplicate logs when global handlers are configured later; set logger.propagate = False when installing the default handler. (Based on your team's feedback about restoring plugin logs by default; this keeps logs visible without duplicating them when global logging is configured.)</comment> <file context> @@ -16,6 +17,12 @@ +if not logger.hasHandlers(): # Only add default handler if user didn't configure logging + handler = logging.StreamHandler(sys.stderr) + handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s")) + logger.addHandler(handler) + logger.setLevel(logging.INFO) + </file context>

cubic-dev-ai · 2025-09-04T16:36:56Z

plugins/communication_protocols/text/src/utcp_text/text_communication_protocol.py

+if not logger.hasHandlers():  # Only add default handler if user didn't configure logging
+    handler = logging.StreamHandler(sys.stderr)
+    handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s"))
+    logger.addHandler(handler)


Adding a handler at import time without disabling propagation can cause duplicate logs if the application configures handlers later; set logger.propagate = False when attaching the default handler.

(Based on your team's feedback about restoring plugin logs by default, this change keeps logs visible while preventing duplicates after later logging configuration.)

Prompt for AI agents

Address the following comment on plugins/communication_protocols/text/src/utcp_text/text_communication_protocol.py at line 32: <comment>Adding a handler at import time without disabling propagation can cause duplicate logs if the application configures handlers later; set logger.propagate = False when attaching the default handler. (Based on your team's feedback about restoring plugin logs by default, this change keeps logs visible while preventing duplicates after later logging configuration.)</comment> <file context> @@ -25,6 +26,13 @@ +if not logger.hasHandlers(): # Only add default handler if user didn't configure logging + handler = logging.StreamHandler(sys.stderr) + handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s")) + logger.addHandler(handler) + logger.setLevel(logging.INFO) + </file context>

Suggested change

logger.addHandler(handler)

logger.addHandler(handler); logger.propagate = False

cubic-dev-ai · 2025-09-04T16:36:56Z

plugins/communication_protocols/http/src/utcp_http/sse_communication_protocol.py

+if not logger.hasHandlers():  # Only add default handler if user didn't configure logging
+    handler = logging.StreamHandler(sys.stderr)
+    handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s"))
+    logger.addHandler(handler)


Adding a handler without disabling propagation can produce duplicate log entries if the app configures root/ancestor handlers after this module is imported; disable propagation when installing the default handler.

(Based on your team's feedback about restoring plugin logs by adding default logging handlers.)

Prompt for AI agents

Address the following comment on plugins/communication_protocols/http/src/utcp_http/sse_communication_protocol.py at line 28: <comment>Adding a handler without disabling propagation can produce duplicate log entries if the app configures root/ancestor handlers after this module is imported; disable propagation when installing the default handler. (Based on your team's feedback about restoring plugin logs by adding default logging handlers.)</comment> <file context> @@ -21,6 +22,12 @@ +if not logger.hasHandlers(): # Only add default handler if user didn't configure logging + handler = logging.StreamHandler(sys.stderr) + handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s")) + logger.addHandler(handler) + logger.setLevel(logging.INFO) + </file context>

cubic-dev-ai · 2025-09-04T16:36:56Z

plugins/communication_protocols/http/src/utcp_http/http_communication_protocol.py

+if not logger.hasHandlers():  # Only add default handler if user didn't configure logging
+    handler = logging.StreamHandler(sys.stderr)
+    handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s"))
+    logger.addHandler(handler)


Adding a handler without disabling propagation can cause duplicate logs when global/root handlers are configured later. Set logger.propagate = False after adding the handler.

(Based on your team's feedback about restoring plugin logs by default, this ensures logs are shown without duplication when users later configure global logging.)

Prompt for AI agents

Address the following comment on plugins/communication_protocols/http/src/utcp_http/http_communication_protocol.py at line 43: <comment>Adding a handler without disabling propagation can cause duplicate logs when global/root handlers are configured later. Set logger.propagate = False after adding the handler. (Based on your team's feedback about restoring plugin logs by default, this ensures logs are shown without duplication when users later configure global logging.)</comment> <file context> @@ -36,6 +37,12 @@ +if not logger.hasHandlers(): # Only add default handler if user didn't configure logging + handler = logging.StreamHandler(sys.stderr) + handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s")) + logger.addHandler(handler) + logger.setLevel(logging.INFO) + </file context>

Suggested change

logger.addHandler(handler)

logger.addHandler(handler); logger.propagate = False

cubic-dev-ai · 2025-09-04T16:36:56Z

plugins/communication_protocols/cli/src/utcp_cli/cli_communication_protocol.py

+if not logger.hasHandlers():  # Only add default handler if user didn't configure logging
+    handler = logging.StreamHandler(sys.stderr)
+    handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s"))
+    logger.addHandler(handler)


Adding a handler without disabling propagation can cause duplicate logs if global handlers are configured later; set propagate=False when attaching the default handler.

(Based on your team's feedback about restoring plugin logs by default, this ensures logs show once without duplication when apps later configure logging.)

Prompt for AI agents

Address the following comment on plugins/communication_protocols/cli/src/utcp_cli/cli_communication_protocol.py at line 42: <comment>Adding a handler without disabling propagation can cause duplicate logs if global handlers are configured later; set propagate=False when attaching the default handler. (Based on your team's feedback about restoring plugin logs by default, this ensures logs show once without duplication when apps later configure logging.)</comment> <file context> @@ -35,6 +36,12 @@ +if not logger.hasHandlers(): # Only add default handler if user didn't configure logging + handler = logging.StreamHandler(sys.stderr) + handler.setFormatter(logging.Formatter("%(asctime)s [%(levelname)s] %(filename)s:%(lineno)d - %(message)s")) + logger.addHandler(handler) + logger.setLevel(logging.INFO) + </file context>

Fix plugin logs not showing and mcp register tools

1dc0a0f

AndreiGS requested a review from h3xxit August 31, 2025 17:35

Add tool name

5c145a3

cubic-dev-ai bot reviewed Aug 31, 2025

View reviewed changes

AndreiGS closed this Aug 31, 2025

Performance optimisation

133c187

AndreiGS reopened this Aug 31, 2025

h3xxit and others added 6 commits September 2, 2025 14:08

Update plugins/communication_protocols/http/src/utcp_http/http_commun…

a27941e

…ication_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Update plugins/communication_protocols/http/src/utcp_http/sse_communi…

68b06be

…cation_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Update plugins/communication_protocols/gql/src/utcp_gql/gql_communica…

33785d0

…tion_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Update plugins/communication_protocols/mcp/src/utcp_mcp/mcp_communica…

677ec11

…tion_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Update plugins/communication_protocols/cli/src/utcp_cli/cli_communica…

0887a00

…tion_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

Update plugins/communication_protocols/text/src/utcp_text/text_commun…

26ba8c3

…ication_protocol.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

universal-tool-calling-protocol deleted a comment from cubic-dev-ai bot Sep 2, 2025

h3xxit requested changes Sep 2, 2025

View reviewed changes

core/src/utcp/implementations/utcp_client_implementation.py Outdated Show resolved Hide resolved

plugins/communication_protocols/http/src/utcp_http/streamable_http_communication_protocol.py Outdated Show resolved Hide resolved

h3xxit mentioned this pull request Sep 2, 2025

MCP plugin not working! #54

Closed

AndreiGS added 4 commits September 4, 2025 09:42

Revert mcp specific config

c685a6e

Add server name to mcp tool

7c8f0d2

Fix mcp tests

c23b594

Replace handlers with hasHandlers()

1320bf5

cubic-dev-ai bot reviewed Sep 4, 2025

View reviewed changes

h3xxit merged commit fe3aad0 into dev Sep 5, 2025
10 checks passed

	logger.addHandler(handler)
	logger.addHandler(handler); logger.propagate = False

Uh oh!

MCP register tools #57

MCP register tools #57

Uh oh!

Conversation

AndreiGS commented Aug 31, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

h3xxit commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

h3xxit commented Sep 4, 2025

Uh oh!

cubic-dev-ai bot commented Sep 4, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndreiGS commented Aug 31, 2025 •

edited by cubic-dev-ai bot

Loading

h3xxit commented Sep 2, 2025 •

edited

Loading