Add search functionality and display page #20
Conversation
|
@miltontony I've updated this PR with the |
springboard/views.py
Outdated
|
@miltontony last |
|
Does this still need a review? |
|
@smn not sure, but I'd like your input on this. This is the first stuff copied from unicore-cms and the structure might need to change to set a better precedent for springboard. |
springboard/templates/molecules.html
Outdated
There was a problem hiding this comment.
There's a route_url template filter that may be nicer to use.
|
Sorry, very late review on some initial work that I think @nathanbegbie did ages ago. |
|
@smn @Rizziepit, sorry, was working on this before my 2 week hiatus. Ran into issues with locales and getting certain search tests related to language to work, so there's now this; https://github.com/universalcore/springboard/tree/feature/issue-21-add-locale-change which I wanted to finish, merge into develop and then pull into this branch. Will get back on this after lunch. |
|
@nathanbegbie cool, I turned #21 into a pull request so we can review that one first. |
…eature/issue-20-add-search getting latest changes to develop branch
|
@nathanbegbie can you open a PR just for the pagination parts? I need pagination for https://github.com/universalcore/springboard-iogt, plus I think pagination will benefit from being reviewed separately. |
|
@Rizziepit I'm exam-ing at the mo, I can get back on this on Thursday ~12pm. Is that too late? |
|
@nathanbegbie I forgot about exams. No prob. I'm going to go ahead and split this up then, and land the pagination part. |
Conflicts: springboard/tests/test_utils.py springboard/utils.py
|
@nathanbegbie pagination has been landed and I merged it back into this branch. |
|
@Rizziepit @miltontony @smn Ready for review |
|
👍 |
No description provided.