Skip to content

Conversation

@Rizziepit
Copy link
Contributor

No description provided.

@Rizziepit
Copy link
Contributor Author

@smn @miltontony ready for review.

This is almost exactly the same as unicore-cms but I changed Paginator.total_count to do results.count() instead of len(results) for an S object. I also added a paginate filter.

@miltontony
Copy link
Contributor

👍

@Rizziepit Rizziepit merged commit 3c9c546 into develop Jun 1, 2015
@smn
Copy link
Contributor

smn commented Jun 1, 2015

Hm in the original implementation the .count() stuff was implemented in the EGPaginator subclass.

@smn
Copy link
Contributor

smn commented Jun 1, 2015

Nothing to change here but just noting that this .count() change already existed.

@Rizziepit
Copy link
Contributor Author

Oops, I forgot to mention that. I removed EGPaginator and made Paginator handle S objects instead. EGPaginator was doing other stuff like returning a generator that calls to_object. It was meant as a drop-in replacement in unicore-cms, but seemed overkill for springboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants