Skip to content

Commit 56f47e1

Browse files
committed
fix(types): return type is normal Promise or void
1 parent b23cbe7 commit 56f47e1

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/hookable.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import type {
1111
NestedHooks,
1212
HookCallback,
1313
HookKeys,
14-
Thenable,
1514
} from "./types.ts";
1615

1716
type InferCallback<HT, HN extends keyof HT> = HT[HN] extends HookCallback
@@ -195,14 +194,14 @@ export class Hookable<
195194
callHook<NameT extends HookNameT>(
196195
name: NameT,
197196
...args: Parameters<InferCallback<HooksT, NameT>>
198-
): Thenable<any> | void {
197+
): Promise<any> | void {
199198
return this.callHookWith(serialTaskCaller, name, args);
200199
}
201200

202201
callHookParallel<NameT extends HookNameT>(
203202
name: NameT,
204203
...args: Parameters<InferCallback<HooksT, NameT>>
205-
): Thenable<any[]> | void {
204+
): Promise<any[]> | void {
206205
return this.callHookWith(parallelTaskCaller, name, args);
207206
}
208207

@@ -321,7 +320,7 @@ export class HookableCore<
321320
callHook<NameT extends HookNameT>(
322321
name: NameT,
323322
...args: Parameters<InferCallback<HooksT, NameT>>
324-
): Thenable<any> | void {
323+
): Promise<any> | void {
325324
const hooks = this._hooks[name];
326325
if (!hooks || hooks.length === 0) {
327326
return;

src/types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ export type HookKeys<T> = keyof T & string;
66
export type DeprecatedHook<T> = { message?: string; to: HookKeys<T> };
77
export type DeprecatedHooks<T> = { [name in HookKeys<T>]: DeprecatedHook<T> };
88

9-
export type Thenable<T> = Promise<T> | T;
10-
119
// Utilities
1210
type ValueOf<C> = C extends Record<any, any> ? C[keyof C] : never;
1311
type Strings<T> = Exclude<keyof T, number | symbol>;

0 commit comments

Comments
 (0)