perf: pass name arg to caller seperately

Co-authored-by: Daniel Roe <daniel@roe.dev>

Author: pi0

README.md

@@ -163,10 +163,11 @@ Used by class itself to **sequentially** call handlers of a specific hook.
 
 If you need custom control over how hooks are called, you can provide a custom function that will receive an array of handlers of a specific hook.
 
-`callerFn` if a callback function that accepts two arguments, `hooks` and `args`:
+`callerFn` if a callback function that accepts 3 arguments, `hooks`, `args` and `name`:
 
 - `hooks`: Array of user hooks to be called
 - `args`: Array of arguments that should be passed each time calling a hook
+- `name`: Name of the hook
 
 ### `deprecateHook (old, name)`
 

src/hookable.ts

@@ -210,6 +210,7 @@ export class Hookable<
     CallFunction extends (
       hooks: HookCallback[],
       args: Parameters<InferCallback<HooksT, NameT>>,
+      name: NameT,
     ) => any,
   >(
     caller: CallFunction,
@@ -221,10 +222,10 @@ export class Hookable<
     if (this._before) {
       callEachWith(this._before, event);
     }
-    const _args = args?.length ? [name, ...args] : [name];
     const result = caller(
       this._hooks[name] ? [...this._hooks[name]] : [],
-      _args as Parameters<InferCallback<HooksT, NameT>>,
+      args as Parameters<InferCallback<HooksT, NameT>>,
+      name,
     );
     if ((result as any) instanceof Promise) {
       return result.finally(() => {

src/utils.ts

@@ -100,18 +100,20 @@ export function callHooks(
 export function serialTaskCaller(
   hooks: HookCallback[],
   args: any[],
+  name: string,
 ): Promise<any> | void {
   if (hooks.length > 0) {
-    return callHooks(hooks, args, 0, createTask(args.shift()));
+    return callHooks(hooks, args, 0, createTask(name));
   }
 }
 
 export function parallelTaskCaller(
   hooks: HookCallback[],
   args: any[],
+  name: string,
 ): Promise<any> | void {
   if (hooks.length > 0) {
-    const task = createTask(args.shift());
+    const task = createTask(name);
     return Promise.all(hooks.map((hook) => task.run(() => hook(...args))));
   }
 }