chore: TSLint fixes

Author: roman.vasilev

.eslintrc.js

@@ -26,6 +26,7 @@ module.exports = {
         'no-unused-vars': 0,
         'indent': 0,
         'unicorn/import-index': 0,
+        'no-dupe-class-members': 0,
         'import/newline-after-import': 0,
         'import/no-duplicates': 1,
         'import/max-dependencies': [1, { 'max': 10 }],

src/custom-error.ts

@@ -1,5 +1,8 @@
 export type CustomErrorOptions = { [K in Exclude<keyof CustomError, 'stack' | 'name'>]?: CustomError[K] };
 
+/**
+ * Base class for custom errors
+ */
 export class CustomError extends Error {
 
     readonly status: number;
@@ -9,34 +12,28 @@ export class CustomError extends Error {
 
     constructor(options: CustomErrorOptions);
     constructor(...args: any[]);
-    constructor(...args: any[]) {
+    constructor(...args: any[]) { // tslint:disable-line:cognitive-complexity
         let message: string | undefined;
         let status: number = 0;
         let data: any;
         let code: string | undefined;
         let inner: Error | undefined;
         for (const arg of args) {
             const typeofArg = typeof arg;
-            switch (true) {
-                case message !== undefined && typeofArg === 'string': {
-                    code = arg;
-                } break;
-                case typeofArg === 'string': {
-                    message = arg;
-                } break;
-                case typeofArg === 'number': {
-                    status = arg;
-                } break;
-                case arg instanceof Error: {
-                    inner = arg;
-                } break;
-                case typeofArg === 'object': {
-                    if ('status' in arg) { status = arg.status; }
-                    if ('message' in arg) { message = arg.message; }
-                    if ('data' in arg) { data = arg.data; }
-                    if ('code' in arg) { code = arg.code; }
-                    if ('inner' in arg) { inner = arg.inner; }
-                } break;
+            if (message !== undefined && typeofArg === 'string') {
+                code = arg;
+            } else if (typeofArg === 'string') {
+                message = arg;
+            } else if (typeofArg === 'number') {
+                status = arg;
+            } else if (arg instanceof Error) {
+                inner = arg;
+            } else if (typeofArg === 'object') {
+                if ('status' in arg) { status = arg.status; }
+                if ('message' in arg) { message = arg.message; }
+                if ('data' in arg) { data = arg.data; }
+                if ('code' in arg) { code = arg.code; }
+                if ('inner' in arg) { inner = arg.inner; }
             }
         }
         super(message);

src/exception-error.ts

@@ -1,5 +1,8 @@
 import { CustomError } from './custom-error';
 
+/**
+ * General unknown error.
+ */
 export class ExceptionError extends CustomError {
 
     constructor(...args: any[]);

src/forbidden-error.ts

@@ -1,5 +1,10 @@
 import { CustomError, CustomErrorOptions } from './custom-error';
 
+/**
+ * Forbidden error, defaults:
+ * status: 403
+ * message: You don't have permission to do that.
+ */
 export class ForbiddenError extends CustomError {
 
     constructor(resource: string);
@@ -10,11 +15,11 @@ export class ForbiddenError extends CustomError {
             const [resource] = args;
             data = { resource };
         }
-        args.unshift({
+        args.unshift(<CustomErrorOptions>{
             data,
             status: 403,
             message: `You don't have permission to do that.`,
-        } as CustomErrorOptions);
-        super(...args as []);
+        });
+        super(...args);
     }
 }

src/index.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable tslint/config */
 import { ExceptionError } from './exception-error';
 import { ForbiddenError } from './forbidden-error';
 import { NotFoundError } from './notfound-error';

src/notfound-error.ts

@@ -1,9 +1,13 @@
 import { CustomError } from './custom-error';
 
+/**
+ * Not found error, defaults:
+ * status: 404
+ */
 export class NotFoundError extends CustomError {
 
     constructor(...args: any[]);
     constructor(...args: any[]) {
-        super(404, ...args as []);
+        super(404, ...args);
     }
 }

src/validation-error.ts

@@ -1,5 +1,9 @@
 import { CustomErrorOptions, CustomError } from './custom-error';
 
+/**
+ * Validation error, defaults:
+ * status: 400
+ */
 export class ValidationError extends CustomError {
 
     constructor(options: CustomErrorOptions);

tslint.json

@@ -34,6 +34,8 @@
     "interface-name": false,
     "ban-types": false,
     "no-relative-imports": false,
-    "missing-jsdoc": false
+    "missing-jsdoc": false,
+    "export-name": false,
+    "no-any": false
   }
 }