fix: config written with no changes #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
OmgImAlexis
commented
Sep 21, 2022
| "bundle": "pkg . --public", | ||
| "build": "npm run compile && npm run bundle", | ||
| "build:docker": "docker compose run --rm builder", | ||
| "build:docker": "docker-compose run --rm builder", |
Contributor
Author
There was a problem hiding this comment.
Can we please use docker compose not docker-compose so it uses the newer runner? It's a lot nicer on windows for the output and doesn't randomly clear the screen for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing the old and new state we need to stringify the object as
===with two objects will returnfalseas they're not the same object.