-
Notifications
You must be signed in to change notification settings - Fork 10
fix(cli): support --log-level for start and restart cmds
#1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3cd0d30
fix: support `--log-level`
pujitm ad20aef
fix type check
pujitm 393d826
add temporary logging to restart command
pujitm 082bb58
fix: incorrect reference to parsed log level option
pujitm eba3534
doc: usage of LOG_LEVEL env var
pujitm 3b011d9
refactor: simplify default --log-level value
pujitm 9aec6e7
add fatal log level option
pujitm aad2b5b
make log level parsing stricter
pujitm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Don’t clobber existing PM2 env when flag is omitted; only set LOG_LEVEL when present.
Currently we always pass
LOG_LEVEL, which can override the process’s saved/env-configured level. Respect “fallback to existing LOG_LEVEL” by conditionally setting it.async run(_?: string[], options: LogLevelOptions = {}): Promise<void> { try { this.logger.info('Restarting the Unraid API...'); - const env = { LOG_LEVEL: options.logLevel }; + // Use explicit flag if provided; else use shell env if set; else don't override PM2 env. + const level = + options.logLevel ?? + (process.env.LOG_LEVEL ? parseLogLevelOption(process.env.LOG_LEVEL) : undefined); + const env: NodeJS.ProcessEnv | undefined = level ? { LOG_LEVEL: level } : undefined; const { stderr, stdout } = await this.pm2.run( - { tag: 'PM2 Restart', raw: true, extendEnv: true, env }, + { tag: 'PM2 Restart', raw: true, extendEnv: true, ...(env ? { env } : {}) }, 'restart', ECOSYSTEM_PATH, '--update-env' );🤖 Prompt for AI Agents