refactor: simplify iframe styling and remove sidebar visibility logic #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning Rate limit exceeded@elibosley has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 Walkthrough📝 WalkthroughPre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
Comment |
- Eliminated the `sidebar` parameter from the iframe configuration details and related examples in the documentation. - Updated the `buildDocsUrl` function to reflect this change, simplifying the URL construction process. - Adjusted related guidance to focus on essential parameters for iframe usage.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
elibosley
changed the title
Contributor
|
- Introduced a new optional query parameter `lang=<locale>` for setting the initial Docs language in the iframe. - Updated the `buildDocsUrl` function to accommodate the new language parameter, ensuring generated URLs reflect the selected locale. - Adjusted documentation to clarify the usage of the new language option.
- Removed the `lang` parameter and replaced it with `locale` for better clarity in setting the initial Docs language. - Introduced a new function, `prefixLocale`, to handle locale-specific URL construction. - Updated the `buildDocsUrl` function to utilize the new locale handling, ensuring URLs reflect the desired language segment. - Revised documentation to clarify the usage of the locale parameter and its impact on the iframe experience.
- Simplified the conditions for running jobs in the PR workflow by removing specific event types for `pull_request`. - Adjusted the checkout action to use the full repository name and reference from the pull request context. - Ensured lint fixes are pushed to the correct branch reference based on the pull request context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit
Bug Fixes
Chores
Documentation